public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Shannon Sterz" <s.sterz@proxmox.com>, <pdm-devel@lists.proxmox.com>
Subject: Re: [PATCH datacenter-manager v2 0/2] fix adding users manually for openid/ldap/ad realms
Date: Thu, 12 Feb 2026 14:18:35 +0100	[thread overview]
Message-ID: <DGD0H8PLWP50.2GLO6B20E59IQ@proxmox.com> (raw)
In-Reply-To: <20260209094349.34075-1-s.sterz@proxmox.com>

On Mon Feb 9, 2026 at 10:43 AM CET, Shannon Sterz wrote:
> currently, when adding a new user manually through the ui, a password
> needs to be entered for all realms but the pam realm. however, only for
> the pdm/product realm itself do we store a password. so don't require
> these fields for any other realm.
>
> also adds a dummy authenticator implementation for openid realms. this
> is necessary, because looking up whether an authenticator is present is
> used for validating that a realm exists when adding a user. so add a
> dummy authenticator for openid realms.
>
> changes since v1
>
> * dropped a `cargo fmt` commit that is no longer necessary
> * patch 1/1 of the original series was applied to yew-comp already, so i
>   dropped it here
> * fixed a typo in the commit message of 2/2
>
> proxmox-datacenter-manager:
>
> Shannon Sterz (2):
>   fix #7182: server: auth: add dummy openid authenticator
>   ui: set product realm so that the add user dialogs are rendered
>     properly
>
>  server/src/auth/mod.rs      | 61 ++++++++++++++++++++++++++++++-------
>  ui/src/configuration/mod.rs |  2 +-
>  2 files changed, 51 insertions(+), 12 deletions(-)
>
>
> Summary over all repositories:
>   2 files changed, 51 insertions(+), 12 deletions(-)
>
> --
> Generated by git-murpp 0.8.1


Looks good to me. Tested it against a locally running keycloak server.

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Tested-by: Lukas Wagner <l.wagner@proxmox.com>




  parent reply	other threads:[~2026-02-12 13:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-09  9:43 Shannon Sterz
2026-02-09  9:43 ` [PATCH datacenter-manager v2 1/2] fix #7182: server: auth: add dummy openid authenticator Shannon Sterz
2026-02-09  9:43 ` [PATCH datacenter-manager v2 2/2] ui: set product realm so that the add user dialogs are rendered properly Shannon Sterz
2026-02-12 13:18 ` Lukas Wagner [this message]
2026-02-13  8:34 ` applied: [PATCH datacenter-manager v2 0/2] fix adding users manually for openid/ldap/ad realms Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGD0H8PLWP50.2GLO6B20E59IQ@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    --cc=s.sterz@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal