Re: [PATCH datacenter-manager 4/5] parallel fetcher: improve result type ergonomics

["Lukas Wagner" <l.wagner@proxmox.com>]

On Thu Feb 5, 2026 at 7:17 PM CET, Thomas Lamprecht wrote:
> Am 04.02.26 um 16:27 schrieb Lukas Wagner:
>> Completely overhaul the *Result types:
>>   - use the term 'Outcome' instead of result, to avoid confusion with
>>     Rust's Result type
>
> I do not want to bikeshed this to much, but if we touch it then a bit
> might be ok, with that in mind: why not Response? Outcome just has a bit
> to abstract ring to me.

No particular reason and a very sensible suggestion, after giving it
some thought and seeing the suggested names in context, I also prefer it
to *Outcome -- will send a v2 for the last two patches with the names
changed accordingly.

Thanks!

>
> Rest seems OK to me, albeit I only skimmed the changes. The module level
> docs are highly appreciated, but won't apply them until above is cleared
> up.
>
>>   - use generics to avoid the awkwardness of accessing the node outcome
>>     of a single node when using do_for_all_remotes (we only call out to
>>     a single node anyways)
>>   - implement .iter()/.into_iter() where it makes sense for conveniently
>>     iterating over remote outcomes and node outcomes
>>   - make all members private and offer getters to access fields
>>   - use a sorted vec as an internal data structure for storing
>>     remote outcomes instead a hash map. This avoids the awkwardness of
>>     having the remote name as key *and* in the struct that is used as a
>>     value. Since the vec is sorted by the remote name, we still can
>>     access specific remotes quite effectively via binary search.