* [PATCH proxmox-datacenter-manager] pdm-api-types: Add acl feature to access-control
@ 2026-02-02 13:49 Maximiliano Sandoval
2026-02-04 9:37 ` applied: " Lukas Wagner
2026-02-04 9:57 ` Thomas Lamprecht
0 siblings, 2 replies; 4+ messages in thread
From: Maximiliano Sandoval @ 2026-02-02 13:49 UTC (permalink / raw)
To: pdm-devel
To match the changes made in
https://git.proxmox.com/?p=proxmox.git;a=commitdiff;h=47defa79bd10991d28757a690f7dc283805b2768.
This fixes the following error while running `cargo build`:
```
$ cargo build
Compiling pdm-api-types v1.0.0 (/home/msandoval/Projects/proxmox-datacenter-manager/lib/pdm-api-types)
error[E0433]: failed to resolve: could not find `init` in `proxmox_access_control`
--> lib/pdm-api-types/src/acl.rs:192:30
|
192 | impl proxmox_access_control::init::AccessControlConfig for AccessControlConfig {
| ^^^^ could not find `init` in `proxmox_access_control`
|
note: found an item that was configured out
--> /usr/share/cargo/registry/proxmox-access-control-1.3.1/src/lib.rs:12:9
|
11 | #[cfg(feature = "acl")]
| --------------- the item is gated behind the `acl` feature
12 | pub mod init;
| ^^^^
error[E0433]: failed to resolve: could not find `acl` in `proxmox_access_control`
--> lib/pdm-api-types/src/acl.rs:257:50
|
257 | let components = proxmox_access_control::acl::split_acl_path(path);
| ^^^ could not find `acl` in `proxmox_access_control`
|
note: found an item that was configured out
--> /usr/share/cargo/registry/proxmox-access-control-1.3.1/src/lib.rs:6:9
|
5 | #[cfg(feature = "acl")]
| --------------- the item is gated behind the `acl` feature
6 | pub mod acl;
| ^^^
For more information about this error, try `rustc --explain E0433`.
error: could not compile `pdm-api-types` (lib) due to 2 previous errors
```
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
lib/pdm-api-types/Cargo.toml | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/pdm-api-types/Cargo.toml b/lib/pdm-api-types/Cargo.toml
index d6429e6a..7aa7b64e 100644
--- a/lib/pdm-api-types/Cargo.toml
+++ b/lib/pdm-api-types/Cargo.toml
@@ -14,7 +14,7 @@ serde.workspace = true
serde_plain.workspace = true
proxmox-acme-api.workspace = true
-proxmox-access-control.workspace = true
+proxmox-access-control = { workspace = true, features = ["acl"] }
proxmox-auth-api = { workspace = true, features = ["api-types"] }
proxmox-apt-api-types.workspace = true
proxmox-lang.workspace = true
--
2.47.3
^ permalink raw reply [flat|nested] 4+ messages in thread
* applied: [PATCH proxmox-datacenter-manager] pdm-api-types: Add acl feature to access-control
2026-02-02 13:49 [PATCH proxmox-datacenter-manager] pdm-api-types: Add acl feature to access-control Maximiliano Sandoval
@ 2026-02-04 9:37 ` Lukas Wagner
2026-02-04 9:57 ` Thomas Lamprecht
1 sibling, 0 replies; 4+ messages in thread
From: Lukas Wagner @ 2026-02-04 9:37 UTC (permalink / raw)
To: Maximiliano Sandoval, pdm-devel
On Mon Feb 2, 2026 at 2:49 PM CET, Maximiliano Sandoval wrote:
> To match the changes made in
> https://git.proxmox.com/?p=proxmox.git;a=commitdiff;h=47defa79bd10991d28757a690f7dc283805b2768.
>
> This fixes the following error while running `cargo build`:
>
> ```
> $ cargo build
> Compiling pdm-api-types v1.0.0 (/home/msandoval/Projects/proxmox-datacenter-manager/lib/pdm-api-types)
> error[E0433]: failed to resolve: could not find `init` in `proxmox_access_control`
> --> lib/pdm-api-types/src/acl.rs:192:30
> |
> 192 | impl proxmox_access_control::init::AccessControlConfig for AccessControlConfig {
> | ^^^^ could not find `init` in `proxmox_access_control`
> |
> note: found an item that was configured out
> --> /usr/share/cargo/registry/proxmox-access-control-1.3.1/src/lib.rs:12:9
> |
> 11 | #[cfg(feature = "acl")]
> | --------------- the item is gated behind the `acl` feature
> 12 | pub mod init;
> | ^^^^
>
> error[E0433]: failed to resolve: could not find `acl` in `proxmox_access_control`
> --> lib/pdm-api-types/src/acl.rs:257:50
> |
> 257 | let components = proxmox_access_control::acl::split_acl_path(path);
> | ^^^ could not find `acl` in `proxmox_access_control`
> |
> note: found an item that was configured out
> --> /usr/share/cargo/registry/proxmox-access-control-1.3.1/src/lib.rs:6:9
> |
> 5 | #[cfg(feature = "acl")]
> | --------------- the item is gated behind the `acl` feature
> 6 | pub mod acl;
> | ^^^
>
> For more information about this error, try `rustc --explain E0433`.
> error: could not compile `pdm-api-types` (lib) due to 2 previous errors
> ```
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> lib/pdm-api-types/Cargo.toml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/pdm-api-types/Cargo.toml b/lib/pdm-api-types/Cargo.toml
> index d6429e6a..7aa7b64e 100644
> --- a/lib/pdm-api-types/Cargo.toml
> +++ b/lib/pdm-api-types/Cargo.toml
> @@ -14,7 +14,7 @@ serde.workspace = true
> serde_plain.workspace = true
>
> proxmox-acme-api.workspace = true
> -proxmox-access-control.workspace = true
> +proxmox-access-control = { workspace = true, features = ["acl"] }
> proxmox-auth-api = { workspace = true, features = ["api-types"] }
> proxmox-apt-api-types.workspace = true
> proxmox-lang.workspace = true
applied, thank you for the patch!
As discussed off-list with you, I changed the commit message a bit,
removing the quite noisy compiler output with a short textual
explanation.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH proxmox-datacenter-manager] pdm-api-types: Add acl feature to access-control
2026-02-02 13:49 [PATCH proxmox-datacenter-manager] pdm-api-types: Add acl feature to access-control Maximiliano Sandoval
2026-02-04 9:37 ` applied: " Lukas Wagner
@ 2026-02-04 9:57 ` Thomas Lamprecht
2026-02-04 10:33 ` Thomas Lamprecht
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Lamprecht @ 2026-02-04 9:57 UTC (permalink / raw)
To: Maximiliano Sandoval, pdm-devel
Am 02.02.26 um 14:48 schrieb Maximiliano Sandoval:
> To match the changes made in
> https://git.proxmox.com/?p=proxmox.git;a=commitdiff;h=47defa79bd10991d28757a690f7dc283805b2768.
>
> This fixes the following error while running `cargo build`:
>
> ```
> $ cargo build
> Compiling pdm-api-types v1.0.0 (/home/msandoval/Projects/proxmox-datacenter-manager/lib/pdm-api-types)
> error[E0433]: failed to resolve: could not find `init` in `proxmox_access_control`
> --> lib/pdm-api-types/src/acl.rs:192:30
> |
> 192 | impl proxmox_access_control::init::AccessControlConfig for AccessControlConfig {
> | ^^^^ could not find `init` in `proxmox_access_control`
> |
> note: found an item that was configured out
> --> /usr/share/cargo/registry/proxmox-access-control-1.3.1/src/lib.rs:12:9
> |
> 11 | #[cfg(feature = "acl")]
> | --------------- the item is gated behind the `acl` feature
> 12 | pub mod init;
> | ^^^^
>
> error[E0433]: failed to resolve: could not find `acl` in `proxmox_access_control`
> --> lib/pdm-api-types/src/acl.rs:257:50
> |
> 257 | let components = proxmox_access_control::acl::split_acl_path(path);
> | ^^^ could not find `acl` in `proxmox_access_control`
> |
> note: found an item that was configured out
> --> /usr/share/cargo/registry/proxmox-access-control-1.3.1/src/lib.rs:6:9
> |
> 5 | #[cfg(feature = "acl")]
> | --------------- the item is gated behind the `acl` feature
> 6 | pub mod acl;
> | ^^^
>
> For more information about this error, try `rustc --explain E0433`.
> error: could not compile `pdm-api-types` (lib) due to 2 previous errors
> ```
This is just not a good commit message, how is having the whole compiler output
helpful as rationale?
One either has to follow the link or interpret a whole lot of verbose info, as
the compiler cannot be sure about what the actual fix is, that could have
been rather stated explicitly:
proxmox-access-control gained an `acl` feature [0] to provide more granular
access to the ACLTree and related types, which we now need to opt-into here"
[0]: https://git.proxmox.com/?p=proxmox.git;a=commitdiff;h=47defa79bd10991d28757a690f7dc283805b2768.
@Lukas: please keep commit hygiene in mind, such things can also be fixed
up on applying, depending on the changes needed.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> lib/pdm-api-types/Cargo.toml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/pdm-api-types/Cargo.toml b/lib/pdm-api-types/Cargo.toml
> index d6429e6a..7aa7b64e 100644
> --- a/lib/pdm-api-types/Cargo.toml
> +++ b/lib/pdm-api-types/Cargo.toml
> @@ -14,7 +14,7 @@ serde.workspace = true
> serde_plain.workspace = true
>
> proxmox-acme-api.workspace = true
> -proxmox-access-control.workspace = true
> +proxmox-access-control = { workspace = true, features = ["acl"] }
> proxmox-auth-api = { workspace = true, features = ["api-types"] }
> proxmox-apt-api-types.workspace = true
> proxmox-lang.workspace = true
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH proxmox-datacenter-manager] pdm-api-types: Add acl feature to access-control
2026-02-04 9:57 ` Thomas Lamprecht
@ 2026-02-04 10:33 ` Thomas Lamprecht
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Lamprecht @ 2026-02-04 10:33 UTC (permalink / raw)
To: Lukas Wagner; +Cc: pdm-devel
Am 04.02.26 um 10:56 schrieb Thomas Lamprecht:
> @Lukas: please keep commit hygiene in mind, such things can also be fixed
> up on applying, depending on the changes needed.
Ah, you actually did do that, in that case sorry and actually huge
thanks for doing that.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-02-04 10:32 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-02-02 13:49 [PATCH proxmox-datacenter-manager] pdm-api-types: Add acl feature to access-control Maximiliano Sandoval
2026-02-04 9:37 ` applied: " Lukas Wagner
2026-02-04 9:57 ` Thomas Lamprecht
2026-02-04 10:33 ` Thomas Lamprecht
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox