public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Maximiliano Sandoval" <m.sandoval@proxmox.com>,
	<pdm-devel@lists.proxmox.com>
Subject: applied: [PATCH proxmox-datacenter-manager] pdm-api-types: Add acl feature to access-control
Date: Wed, 04 Feb 2026 10:37:27 +0100	[thread overview]
Message-ID: <DG62RKI2L5B9.1URHB3K1W61GN@proxmox.com> (raw)
In-Reply-To: <20260202134926.403503-1-m.sandoval@proxmox.com>

On Mon Feb 2, 2026 at 2:49 PM CET, Maximiliano Sandoval wrote:
> To match the changes made in
> https://git.proxmox.com/?p=proxmox.git;a=commitdiff;h=47defa79bd10991d28757a690f7dc283805b2768.
>
> This fixes the following error while running `cargo build`:
>
> ```
> $ cargo build
>    Compiling pdm-api-types v1.0.0 (/home/msandoval/Projects/proxmox-datacenter-manager/lib/pdm-api-types)
> error[E0433]: failed to resolve: could not find `init` in `proxmox_access_control`
>    --> lib/pdm-api-types/src/acl.rs:192:30
>     |
> 192 | impl proxmox_access_control::init::AccessControlConfig for AccessControlConfig {
>     |                              ^^^^ could not find `init` in `proxmox_access_control`
>     |
> note: found an item that was configured out
>    --> /usr/share/cargo/registry/proxmox-access-control-1.3.1/src/lib.rs:12:9
>     |
>  11 | #[cfg(feature = "acl")]
>     |       --------------- the item is gated behind the `acl` feature
>  12 | pub mod init;
>     |         ^^^^
>
> error[E0433]: failed to resolve: could not find `acl` in `proxmox_access_control`
>    --> lib/pdm-api-types/src/acl.rs:257:50
>     |
> 257 |         let components = proxmox_access_control::acl::split_acl_path(path);
>     |                                                  ^^^ could not find `acl` in `proxmox_access_control`
>     |
> note: found an item that was configured out
>    --> /usr/share/cargo/registry/proxmox-access-control-1.3.1/src/lib.rs:6:9
>     |
>   5 | #[cfg(feature = "acl")]
>     |       --------------- the item is gated behind the `acl` feature
>   6 | pub mod acl;
>     |         ^^^
>
> For more information about this error, try `rustc --explain E0433`.
> error: could not compile `pdm-api-types` (lib) due to 2 previous errors
> ```
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  lib/pdm-api-types/Cargo.toml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/pdm-api-types/Cargo.toml b/lib/pdm-api-types/Cargo.toml
> index d6429e6a..7aa7b64e 100644
> --- a/lib/pdm-api-types/Cargo.toml
> +++ b/lib/pdm-api-types/Cargo.toml
> @@ -14,7 +14,7 @@ serde.workspace = true
>  serde_plain.workspace = true
>  
>  proxmox-acme-api.workspace = true
> -proxmox-access-control.workspace = true
> +proxmox-access-control = { workspace = true, features = ["acl"] }
>  proxmox-auth-api = { workspace = true, features = ["api-types"] }
>  proxmox-apt-api-types.workspace = true
>  proxmox-lang.workspace = true


applied, thank you for the patch!

As discussed off-list with you, I changed the commit message a bit,
removing the quite noisy compiler output with a short textual
explanation.




  reply	other threads:[~2026-02-04  9:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-02 13:49 Maximiliano Sandoval
2026-02-04  9:37 ` Lukas Wagner [this message]
2026-02-04  9:57 ` Thomas Lamprecht
2026-02-04 10:33   ` Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DG62RKI2L5B9.1URHB3K1W61GN@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=m.sandoval@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal