From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox Datacenter Manager development discussion"
<pdm-devel@lists.proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager 0/2] validate remote hostname
Date: Mon, 12 Jan 2026 11:30:34 +0100 [thread overview]
Message-ID: <DFMJHPGFMOZ8.16475FNYXSC8F@proxmox.com> (raw)
In-Reply-To: <20251219123758.151318-1-s.sterz@proxmox.com>
On Fri Dec 19, 2025 at 1:37 PM CET, Shannon Sterz wrote:
> previously the endpoints list in the ui did not validate user input,
> nor did the api when updating a remote. this could lead to an issue
> where a user could configure a remote in a way that made it impossible
> for pdm to connect to it. this series fixes that.
>
> changes since v1:
>
> * add validation to the correct place, thanks @ Dominik Csapak
>
> Shannon Sterz (2):
> ui: node url list: validate list of endpoints
> api types: node url: validate hostname
>
> lib/pdm-api-types/src/lib.rs | 3 +++
> lib/pdm-api-types/src/remotes.rs | 5 ++++-
> ui/src/remotes/node_url_list.rs | 2 ++
> 3 files changed, 9 insertions(+), 1 deletion(-)
>
With the trivial fix mentioned in 1/2 locally:
Tested-by: Lukas Wagner <l.wagner@proxmox.com>
Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
prev parent reply other threads:[~2026-01-12 10:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-19 12:37 Shannon Sterz
2025-12-19 12:37 ` [pdm-devel] [PATCH datacenter-manager 1/2] ui: node url list: validate list of endpoints Shannon Sterz
2026-01-12 10:29 ` Lukas Wagner
2025-12-19 12:37 ` [pdm-devel] [PATCH datacenter-manager 2/2] api types: node url: validate hostname Shannon Sterz
2026-01-12 10:30 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFMJHPGFMOZ8.16475FNYXSC8F@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox