Re: [pdm-devel] [PATCH datacenter-manager v2 1/4] remote tasks: move implementation to server crate

From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Shannon Sterz" <s.sterz@proxmox.com>,
	"Lukas Wagner" <l.wagner@proxmox.com>
Cc: Proxmox Datacenter Manager development discussion
	<pdm-devel@lists.proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager v2 1/4] remote tasks: move implementation to server crate
Date: Mon, 29 Dec 2025 15:54:10 +0100	[thread overview]
Message-ID: <DFASBWNFQC54.2EI89Q361ACRT@proxmox.com> (raw)
In-Reply-To: <DF28PX4WU3VR.19HRZ31SKANFX@proxmox.com>

On Fri Dec 19, 2025 at 2:50 PM CET, Shannon Sterz wrote:
> On Thu Dec 18, 2025 at 3:20 PM CET, Lukas Wagner wrote:
>>  use server::{
>> -    connection,
>> -    parallel_fetcher::{NodeResults, ParallelFetcher},
>> -    pbs_client,
>> -    remote_tasks::{
>> -        self,
>> -        task_cache::{GetTasks, NodeFetchSuccessMap, State, TaskCache, TaskCacheItem},
>> -        KEEP_OLD_FILES, REMOTE_TASKS_DIR, ROTATE_AFTER,
>> -    },
>> +    remote_tasks::{self, refresh_task, REMOTE_TASKS_DIR},
>
> nit: could use module level imports here :)
>

Thanks, will be fixed for v2!

>>      task_utils,
>>  };

[...]

>>
>>
>>      loop {
>>          interval.tick().await;
>> -        if let Err(err) = do_tick(&mut task_state).await {
>> +        if let Err(err) = remote_tasks::refresh_task::handle_timer_tick(&mut task_state).await {
>
> nit: you already import `refresh_task` above. so drop `remote_tasks` in
> front here, should also enable you to drop the `self` import above.
>
>>              log::error!("error when fetching remote tasks: {err:#}");
>>          }
>>      }
>>  }

This as well :)

_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel