From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Lukas Wagner" <l.wagner@proxmox.com>
Cc: Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager/proxmox-yew-comp v2 0/6] manual refresh button for remote task cache
Date: Fri, 19 Dec 2025 14:53:01 +0100 [thread overview]
Message-ID: <DF28RN5R5XJ9.2HPV13SDLXRBU@proxmox.com> (raw)
In-Reply-To: <20251218142007.279631-1-l.wagner@proxmox.com>
On Thu Dec 18, 2025 at 3:20 PM CET, Lukas Wagner wrote:
> This adds the
> POST /remotes/tasks/refresh[?remote=...]
>
> endpoint for manually triggering task collection from a single or all remotes.
>
> The task viewer component is changed so that the refresh button can be wired
> up to trigger this new endpoint.
>
> Changes since v1:
> - Drop the patch which adds the task descriptions of the new
> refresh-task - this one is now included in another patch series
> - Fix a bug where the view would not automatically display new tasks
> after the refresh task finished
>
>
> proxmox-yew-comp:
>
> Lukas Wagner (2):
> task list: add support for starting refresh tasks
> loadable component: don't trigger reload when starting a task
>
> src/loadable_component.rs | 1 -
> src/tasks.rs | 21 ++++++++++++++++++++-
> 2 files changed, 20 insertions(+), 2 deletions(-)
>
>
> proxmox-datacenter-manager:
>
> Lukas Wagner (4):
> remote tasks: move implementation to server crate
> remote tasks: implement `refresh_task_cache` for manual task fetching
> api: add /remotes/tasks/refresh
> ui: remote task view: set refresh_task_url property for task viewer
>
> server/src/api/remote_tasks.rs | 90 ++-
> .../tasks/remote_tasks.rs | 535 +----------------
> server/src/remote_tasks/mod.rs | 1 +
> server/src/remote_tasks/refresh_task.rs | 544 ++++++++++++++++++
> ui/src/remotes/tasks.rs | 14 +-
> 5 files changed, 650 insertions(+), 534 deletions(-)
> create mode 100644 server/src/remote_tasks/refresh_task.rs
>
>
> Summary over all repositories:
> 7 files changed, 670 insertions(+), 536 deletions(-)
took a look at this series, generally the changes look good to me, just
had two smaller notes that i left on the respective patches. so consider
this:
Reviewed-by: Shannon Sterz <s.sterz@proxmox.com>
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
prev parent reply other threads:[~2025-12-19 13:52 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-18 14:20 Lukas Wagner
2025-12-18 14:20 ` [pdm-devel] [PATCH proxmox-yew-comp v2 1/2] task list: add support for starting refresh tasks Lukas Wagner
2025-12-18 14:20 ` [pdm-devel] [PATCH proxmox-yew-comp v2 2/2] loadable component: don't trigger reload when starting a task Lukas Wagner
2025-12-18 14:20 ` [pdm-devel] [PATCH datacenter-manager v2 1/4] remote tasks: move implementation to server crate Lukas Wagner
2025-12-19 13:50 ` Shannon Sterz
2025-12-18 14:20 ` [pdm-devel] [PATCH datacenter-manager v2 2/4] remote tasks: implement `refresh_task_cache` for manual task fetching Lukas Wagner
2025-12-18 14:20 ` [pdm-devel] [PATCH datacenter-manager v2 3/4] api: add /remotes/tasks/refresh Lukas Wagner
2025-12-19 13:52 ` Shannon Sterz
2025-12-18 14:20 ` [pdm-devel] [PATCH datacenter-manager v2 4/4] ui: remote task view: set refresh_task_url property for task viewer Lukas Wagner
2025-12-19 13:53 ` Shannon Sterz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DF28RN5R5XJ9.2HPV13SDLXRBU@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox