From: "Shannon Sterz" <s.sterz@proxmox.com>
To: <pdm-devel@lists.proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager] ui: use RenderFn instead of TextRenderFn
Date: Fri, 19 Dec 2025 13:52:08 +0100 [thread overview]
Message-ID: <DF27GMTQKWSV.3CAENOJPIPT63@proxmox.com> (raw)
In-Reply-To: <DF276RN9JA1X.1Y6X2826W4THP@proxmox.com>
On Fri Dec 19, 2025 at 1:40 PM CET, Shannon Sterz wrote:
> Superseded-by: https://lore.proxmox.com/all/20251219123758.151318-2-s.sterz@proxmox.com/T/#t
sorry ignore this, this is still the current and correct fix. the series
linked to above is for something else
>
> On Thu Dec 11, 2025 at 11:10 AM CET, Shannon Sterz wrote:
>> TextRenderFn has been removed from proxmox-yew-widget-toolkit
>> recently. use the generic RenderFn instead.
>>
>> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
>> ---
>>
>> note that this should only be applied once proxmox-yew-widget-toolkit
>> has been bumped. this isn't yet an issue, but i didn't find a patch for
>> this on list yet. hence, i'm sending this now so that it isn't
>> forgotten.
>>
>> ui/src/main.rs | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/ui/src/main.rs b/ui/src/main.rs
>> index 5f859db..2bd900e 100644
>> --- a/ui/src/main.rs
>> +++ b/ui/src/main.rs
>> @@ -7,7 +7,7 @@ use web_sys::HtmlElement;
>> use yew::prelude::*;
>>
>> use pwt::prelude::*;
>> -use pwt::props::TextRenderFn;
>> +use pwt::props::RenderFn;
>> use pwt::state::{Loader, PersistentState, SharedStateObserver};
>> use pwt::widget::{Column, DesktopApp, Dialog, Mask};
>> use pwt::AsyncPool;
>> @@ -346,9 +346,7 @@ impl Component for DatacenterManagerApp {
>> </ContextProvider<RemoteList>>
>> </ContextProvider<SearchProvider>>
>> })
>> - .catalog_url_builder(TextRenderFn::new(|lang| {
>> - format!("locale/catalog-{lang}.mo")
>> - }))
>> + .catalog_url_builder(RenderFn::new(|lang| format!("locale/catalog-{lang}.mo")))
>> .into()
>> }
>> }
>> --
>> 2.47.3
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-12-19 12:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-11 10:10 Shannon Sterz
2025-12-11 10:33 ` Dominik Csapak
2025-12-19 11:24 ` Shannon Sterz
2025-12-19 12:40 ` Shannon Sterz
2025-12-19 12:52 ` Shannon Sterz [this message]
2025-12-19 12:50 ` [pdm-devel] applied: " Fabian Grünbichler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DF27GMTQKWSV.3CAENOJPIPT63@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox