public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pdm-devel] [PATCH datacenter-manager] ui: replace removed TextRenderFn with generic RenderFn
@ 2025-12-17  9:13 Hannes Laimer
  2025-12-17 10:04 ` Lukas Wagner
  0 siblings, 1 reply; 2+ messages in thread
From: Hannes Laimer @ 2025-12-17  9:13 UTC (permalink / raw)
  To: pdm-devel

TextRenderFn was dropped in proxmox-yew-widget-toolkit with
45592dd ("props: make RenderFn's return type generic")

Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
---
noticed cause ui wouldn't build anymore

 ui/src/main.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/ui/src/main.rs b/ui/src/main.rs
index 5f859db..17de7f1 100644
--- a/ui/src/main.rs
+++ b/ui/src/main.rs
@@ -7,7 +7,7 @@ use web_sys::HtmlElement;
 use yew::prelude::*;
 
 use pwt::prelude::*;
-use pwt::props::TextRenderFn;
+use pwt::props::RenderFn;
 use pwt::state::{Loader, PersistentState, SharedStateObserver};
 use pwt::widget::{Column, DesktopApp, Dialog, Mask};
 use pwt::AsyncPool;
@@ -346,7 +346,7 @@ impl Component for DatacenterManagerApp {
                 </ContextProvider<RemoteList>>
             </ContextProvider<SearchProvider>>
         })
-        .catalog_url_builder(TextRenderFn::new(|lang| {
+        .catalog_url_builder(RenderFn::new(|lang| {
             format!("locale/catalog-{lang}.mo")
         }))
         .into()
-- 
2.47.3



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [pdm-devel] [PATCH datacenter-manager] ui: replace removed TextRenderFn with generic RenderFn
  2025-12-17  9:13 [pdm-devel] [PATCH datacenter-manager] ui: replace removed TextRenderFn with generic RenderFn Hannes Laimer
@ 2025-12-17 10:04 ` Lukas Wagner
  0 siblings, 0 replies; 2+ messages in thread
From: Lukas Wagner @ 2025-12-17 10:04 UTC (permalink / raw)
  To: Proxmox Datacenter Manager development discussion, Hannes Laimer

On Wed Dec 17, 2025 at 10:13 AM CET, Hannes Laimer wrote:
> TextRenderFn was dropped in proxmox-yew-widget-toolkit with
> 45592dd ("props: make RenderFn's return type generic")
>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> noticed cause ui wouldn't build anymore
>
>  ui/src/main.rs | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ui/src/main.rs b/ui/src/main.rs
> index 5f859db..17de7f1 100644
> --- a/ui/src/main.rs
> +++ b/ui/src/main.rs
> @@ -7,7 +7,7 @@ use web_sys::HtmlElement;
>  use yew::prelude::*;
>  
>  use pwt::prelude::*;
> -use pwt::props::TextRenderFn;
> +use pwt::props::RenderFn;
>  use pwt::state::{Loader, PersistentState, SharedStateObserver};
>  use pwt::widget::{Column, DesktopApp, Dialog, Mask};
>  use pwt::AsyncPool;
> @@ -346,7 +346,7 @@ impl Component for DatacenterManagerApp {
>                  </ContextProvider<RemoteList>>
>              </ContextProvider<SearchProvider>>
>          })
> -        .catalog_url_builder(TextRenderFn::new(|lang| {
> +        .catalog_url_builder(RenderFn::new(|lang| {
>              format!("locale/catalog-{lang}.mo")
>          }))
>          .into()

just FIY, Shannon has already provided this patch [1], but it has not
been applied yet. It is only needed when building against latest
pwt/yew-comp, but not when building with the currently packaged ones.

[1] https://lore.proxmox.com/pdm-devel/a4598ca9-19a6-4653-813a-0769e42ed111@proxmox.com/T/#t



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-12-17 10:03 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-17  9:13 [pdm-devel] [PATCH datacenter-manager] ui: replace removed TextRenderFn with generic RenderFn Hannes Laimer
2025-12-17 10:04 ` Lukas Wagner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal