From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox Datacenter Manager development discussion"
<pdm-devel@lists.proxmox.com>,
"Hannes Laimer" <h.laimer@proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager] ui: replace removed TextRenderFn with generic RenderFn
Date: Wed, 17 Dec 2025 11:04:34 +0100 [thread overview]
Message-ID: <DF0ENMUTZ8XB.1GACE53SL1RNC@proxmox.com> (raw)
In-Reply-To: <20251217091350.63951-1-h.laimer@proxmox.com>
On Wed Dec 17, 2025 at 10:13 AM CET, Hannes Laimer wrote:
> TextRenderFn was dropped in proxmox-yew-widget-toolkit with
> 45592dd ("props: make RenderFn's return type generic")
>
> Signed-off-by: Hannes Laimer <h.laimer@proxmox.com>
> ---
> noticed cause ui wouldn't build anymore
>
> ui/src/main.rs | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ui/src/main.rs b/ui/src/main.rs
> index 5f859db..17de7f1 100644
> --- a/ui/src/main.rs
> +++ b/ui/src/main.rs
> @@ -7,7 +7,7 @@ use web_sys::HtmlElement;
> use yew::prelude::*;
>
> use pwt::prelude::*;
> -use pwt::props::TextRenderFn;
> +use pwt::props::RenderFn;
> use pwt::state::{Loader, PersistentState, SharedStateObserver};
> use pwt::widget::{Column, DesktopApp, Dialog, Mask};
> use pwt::AsyncPool;
> @@ -346,7 +346,7 @@ impl Component for DatacenterManagerApp {
> </ContextProvider<RemoteList>>
> </ContextProvider<SearchProvider>>
> })
> - .catalog_url_builder(TextRenderFn::new(|lang| {
> + .catalog_url_builder(RenderFn::new(|lang| {
> format!("locale/catalog-{lang}.mo")
> }))
> .into()
just FIY, Shannon has already provided this patch [1], but it has not
been applied yet. It is only needed when building against latest
pwt/yew-comp, but not when building with the currently packaged ones.
[1] https://lore.proxmox.com/pdm-devel/a4598ca9-19a6-4653-813a-0769e42ed111@proxmox.com/T/#t
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
prev parent reply other threads:[~2025-12-17 10:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-17 9:13 Hannes Laimer
2025-12-17 10:04 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DF0ENMUTZ8XB.1GACE53SL1RNC@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox