public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Shannon Sterz" <s.sterz@proxmox.com>
Cc: pdm-devel@lists.proxmox.com
Subject: Re: [pdm-devel] [PATCH datacenter-manager] ui: datastore panel: disable content tab when datastore is offline
Date: Tue, 16 Dec 2025 14:55:10 +0100	[thread overview]
Message-ID: <DEZOXNMFYQ9T.IKQIMUA5H9VL@proxmox.com> (raw)
In-Reply-To: <20251216121218.187920-3-s.sterz@proxmox.com>

On Tue Dec 16, 2025 at 1:12 PM CET, Shannon Sterz wrote:
> and show a tooltip explaining why.
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
>  ui/src/pbs/datastore.rs | 20 +++++++++++++++++++-
>  1 file changed, 19 insertions(+), 1 deletion(-)
>
> diff --git a/ui/src/pbs/datastore.rs b/ui/src/pbs/datastore.rs
> index 274c6ef..9a21caa 100644
> --- a/ui/src/pbs/datastore.rs
> +++ b/ui/src/pbs/datastore.rs
> @@ -5,7 +5,10 @@ use yew::{
>      Component, Properties,
>  };
>
> -use pwt::{css::FlexFit, props::WidgetBuilder, tr, widget::TabBarItem};
> +use pwt::css::FlexFit;
> +use pwt::props::WidgetBuilder;
> +use pwt::tr;
> +use pwt::widget::{TabBarItem, Tooltip};
>
>  use pbs_api_types::DataStoreConfig;
>
> @@ -45,6 +48,13 @@ impl Component for DatastorePanelComp {
>
>      fn view(&self, ctx: &yew::Context<Self>) -> yew::Html {
>          let props = ctx.props();
> +        let offline = props
> +            .config
> +            .maintenance_mode
> +            .as_ref()
> +            .map(|v| v == "offline")
> +            .unwrap_or_default();
> +
>          pwt::widget::TabPanel::new()
>              .router(true)
>              .class(FlexFit)
> @@ -64,6 +74,14 @@ impl Component for DatastorePanelComp {
>                  TabBarItem::new()
>                      .key("content")
>                      .label(tr!("Content"))
> +                    .disabled(offline)
> +                    .tip(
> +                        offline.then_some(
> +                            Tooltip::new(tr!(
> +                        "Only available if the datastore is not in maintenance mode \"offline\"."))
> +                            .into(),
> +                        ),
> +                    )
>                      .icon_class("fa fa-th"),
>                  {
>                      let remote = props.remote.clone();

this doesn't quite work as intended. i'll send a v2 soon, disregard this
for now.


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  reply	other threads:[~2025-12-16 13:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-16 12:12 Shannon Sterz
2025-12-16 13:55 ` Shannon Sterz [this message]
2025-12-16 14:40 ` [pdm-devel] Superseded: " Shannon Sterz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DEZOXNMFYQ9T.IKQIMUA5H9VL@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal