Re: [pdm-devel] [PATCH datacenter-manager v2 12/14] ui: auto-installer: add installations overview panel

From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Lukas Wagner" <l.wagner@proxmox.com>
Cc: Proxmox Datacenter Manager development discussion
	<pdm-devel@lists.proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager v2 12/14] ui: auto-installer: add installations overview panel
Date: Tue, 16 Dec 2025 14:55:04 +0100	[thread overview]
Message-ID: <DEZOXKU8TE4M.1DA9XQRNM1NZJ@proxmox.com> (raw)
In-Reply-To: <DETOUJX8CJOD.3AXSZCG6K3DND@proxmox.com>

On Tue Dec 9, 2025 at 1:35 PM CET, Lukas Wagner wrote:
[..]
>> diff --git a/ui/src/main_menu.rs b/ui/src/main_menu.rs
>> index 18988ea..073b84d 100644
>> --- a/ui/src/main_menu.rs
>> +++ b/ui/src/main_menu.rs
>> @@ -378,6 +379,18 @@ impl Component for PdmMainMenu {
>>              remote_submenu,
>>          );
>>
>> +        let mut autoinstaller_submenu = Menu::new();
>> +
>> +        register_submenu(
>> +            &mut menu,
>> +            &mut content,
>> +            tr!("Automated Installations"),
>> +            "auto-installer",
>> +            Some("fa fa-cubes"),
>> +            |_| AutoInstallerPanel::default().into(),
>> +            autoinstaller_submenu,
>> +        );
>
> I'm not sure whether this should be a top-level menu - but then again,
> I'm not sure where it could go else. Maybe a tab under "Remotes"? Since
> any node that was automatically would realistically be added as a remote
> at some later time?

Yeah, bit hard. Given its two panels, not sure if we want to cram it
under Remotes somewhere. How could these two panels then be sensible
structured to not have two tabs (which would be kinda weird)?

_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel