Re: [pdm-devel] [PATCH datacenter-manager/proxmox 0/6] fix #6914: add option to remove already existing token

["Shan Shaji" <s.shaji@proxmox.com>]

Thank you so much for the nice reviews Michael. One small comment inline. 

On Tue Dec 9, 2025 at 3:56 PM CET, Michael Köppl wrote:
> Quickly tested this with my PDM instance. Noticed that:
> - when removing a remote and checking the option to also remove the
>   token, the user will be unable to remove the remote if it is
>   unreachable. The user will be presented an error, but the remote will
>   remain since the call to remove the token will fail before. This is in
>   contrast to the behavior for removing a remote without the token,
>   which will remove the remote in any case.

This was actually intended. If the token deletion fails for some reason, 
to be on the safe side, i am delibrately not deleting the remote 
from our local config.

> - the admin CLI does not have the delete-token parameter
>
> Other than that, seems to work as advertised. Also had a look at the
> code and left some notes on the individual patches.
>
> Consider this:
> Tested-by: Michael Köppl <m.koeppl@proxmox.com>
>
> On Fri Dec 5, 2025 at 7:04 PM CET, Shan Shaji wrote:
>> If a user removed a remote without deleting its associated token, PDM
>> would not allow re-adding the same remote unless the token name was
>> changed. To fix this, support for optionally deleting the token from
>> the remote has been added.
>>
>> This includes:
>>
>> - CLI: An optional flag to remove the token when removing the remote
>> - UI: A checkbox that allows users to delete the token along with the
>>       remote
>>
>> proxmox-datacenter-manager:
>>
>> Shan Shaji (5):
>>   server: pbs-client: add delete admin token method
>>   server: api: add support to optionally delete token from remote
>>   pdm-client: accept `delete-token` argument for deleting api token
>>   cli: client: add `delete-token` option to delete token from remote
>>   fix: ui: add remove confirmation dialog with optional token deletion
>>
>>  cli/client/src/remotes.rs       |  11 ++-
>>  lib/pdm-client/src/lib.rs       |   6 +-
>>  server/src/api/remotes.rs       |  45 +++++++++++-
>>  server/src/pbs_client.rs        |   9 ++-
>>  ui/src/remotes/config.rs        |  42 +++++++----
>>  ui/src/remotes/mod.rs           |   3 +
>>  ui/src/remotes/remove_remote.rs | 122 ++++++++++++++++++++++++++++++++
>>  7 files changed, 217 insertions(+), 21 deletions(-)
>>  create mode 100644 ui/src/remotes/remove_remote.rs
>>
>>
>> proxmox:
>>
>> Shan Shaji (1):
>>   pve-api-types: generate missing `delete_token` method
>>
>>  pve-api-types/generate.pl           |  1 +
>>  pve-api-types/src/generated/code.rs | 11 +++++++++++
>>  2 files changed, 12 insertions(+)
>>
>>
>> Summary over all repositories:
>>   9 files changed, 229 insertions(+), 21 deletions(-)
>
>
>
> _______________________________________________
> pdm-devel mailing list
> pdm-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel