From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Proxmox Datacenter Manager development discussion"
<pdm-devel@lists.proxmox.com>
Cc: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager 4/5] cli: client: add `delete-token` option to delete token from remote
Date: Tue, 09 Dec 2025 17:25:40 +0100 [thread overview]
Message-ID: <DETTR2QJT637.WT7GHD3EU0T3@proxmox.com> (raw)
In-Reply-To: <DETRRPY756FX.3JT75ATDCWW69@proxmox.com>
On Tue Dec 9, 2025 at 3:52 PM CET, Michael Köppl wrote:
> shouldn't this also be implemented for the admin CLI?
Yes, I missed to include that patch. Will send it in v2.Thank you for
pointing it out.
> On Fri Dec 5, 2025 at 7:04 PM CET, Shan Shaji wrote:
>> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
>> ---
>> cli/client/src/remotes.rs | 11 ++++++++---
>> 1 file changed, 8 insertions(+), 3 deletions(-)
>>
>> diff --git a/cli/client/src/remotes.rs b/cli/client/src/remotes.rs
>> index 4145dac..0b4df3c 100644
>> --- a/cli/client/src/remotes.rs
>> +++ b/cli/client/src/remotes.rs
>> @@ -116,12 +116,17 @@ async fn update_remote(id: String, updater: RemoteUpdater) -> Result<(), Error>
>> input: {
>> properties: {
>> id: { schema: REMOTE_ID_SCHEMA },
>> + "delete-token": {
>> + type: bool,
>> + optional: true,
>> + description: "Remove the API-Token from remote."
>> + }
>> }
>> }
>> )]
>> -/// Add a new remote.
>> -async fn delete_remote(id: String) -> Result<(), Error> {
>> - client()?.delete_remote(&id).await?;
>> +/// Delete a remote.
>> +async fn delete_remote(id: String, delete_token: Option<bool>) -> Result<(), Error> {
>> + client()?.delete_remote(&id, &delete_token).await?;
>> Ok(())
>> }
>>
>
>
>
> _______________________________________________
> pdm-devel mailing list
> pdm-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-12-09 16:25 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-12-05 18:04 [pdm-devel] [PATCH datacenter-manager/proxmox 0/6] fix #6914: add option to remove already existing token Shan Shaji
2025-12-05 18:04 ` [pdm-devel] [PATCH datacenter-manager 1/5] server: pbs-client: add delete admin token method Shan Shaji
2025-12-09 9:36 ` Shannon Sterz
2025-12-05 18:04 ` [pdm-devel] [PATCH datacenter-manager 2/5] server: api: add support to optionally delete token from remote Shan Shaji
2025-12-09 9:36 ` Shannon Sterz
2025-12-09 9:54 ` Shan Shaji
2025-12-09 12:34 ` Michael Köppl
2025-12-09 13:37 ` Shan Shaji
2025-12-05 18:04 ` [pdm-devel] [PATCH datacenter-manager 3/5] pdm-client: accept `delete-token` argument for deleting api token Shan Shaji
2025-12-09 9:36 ` Shannon Sterz
2025-12-09 13:08 ` Michael Köppl
2025-12-05 18:04 ` [pdm-devel] [PATCH datacenter-manager 4/5] cli: client: add `delete-token` option to delete token from remote Shan Shaji
2025-12-09 14:52 ` Michael Köppl
2025-12-09 16:25 ` Shan Shaji [this message]
2025-12-05 18:04 ` [pdm-devel] [PATCH datacenter-manager 5/5] fix: ui: add remove confirmation dialog with optional token deletion Shan Shaji
2025-12-09 9:36 ` Shannon Sterz
2025-12-09 10:08 ` Shan Shaji
2025-12-09 13:38 ` Michael Köppl
2025-12-09 13:52 ` Shan Shaji
2025-12-05 18:04 ` [pdm-devel] [PATCH proxmox 1/1] pve-api-types: generate missing `delete_token` method Shan Shaji
2025-12-09 9:37 ` Shannon Sterz
2025-12-09 14:56 ` [pdm-devel] [PATCH datacenter-manager/proxmox 0/6] fix #6914: add option to remove already existing token Michael Köppl
2025-12-09 17:02 ` Shan Shaji
2025-12-10 16:40 ` Shan Shaji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DETTR2QJT637.WT7GHD3EU0T3@proxmox.com \
--to=s.shaji@proxmox.com \
--cc=pdm-devel-bounces@lists.proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox