public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox Datacenter Manager development discussion"
	<pdm-devel@lists.proxmox.com>,
	"Dominik Csapak" <d.csapak@proxmox.com>
Subject: Re: [pdm-devel] [RFC PATCH datacenter-manager 5/5] ui: main menu: use different icon for pbs remotes
Date: Thu, 04 Dec 2025 16:21:27 +0100	[thread overview]
Message-ID: <DEPJ96AUN14Q.2OF7305DE4SCM@proxmox.com> (raw)
In-Reply-To: <20251204142451.2992215-6-d.csapak@proxmox.com>

On Thu Dec 4, 2025 at 3:20 PM CET, Dominik Csapak wrote:
> In most of the UI, we use 'server' for remotes, 'building' for PVE nodes
> and 'building-o' for PBS nodes.
>
> In the main menu we don't have the information if a remote is a single
> node or not for PVE, but we know if it's PBS. So show the 'building-o'
> for PBS remotes.
>
> This makes it possible to see which kind of remote it is before
> clicking, and wihtout inventing a custom naming scheme.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> We can of course choose different icons here if wanted, e.g. 'floppy-o'
> for pbs remotes?
>
> Maybe the best option would be to create some custom product icons that
> we could use here and maybe for the favicon, etc. ?

Yeah, I think having product-specific icons would be great in the
long-term, in fact I only recently talked to Thomas about the very same
topic.

In the meanwhile, I think using this different icon you used in this
patch is a good stop-gap that should help UX a bit.

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  reply	other threads:[~2025-12-04 15:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-04 14:20 [pdm-devel] [PATCH datacenter-manager 0/5] some ui polishing changes Dominik Csapak
2025-12-04 14:20 ` [pdm-devel] [PATCH datacenter-manager 1/5] ui: pve: remove overview: allow line-breaks for long lines Dominik Csapak
2025-12-04 14:20 ` [pdm-devel] [PATCH datacenter-manager 2/5] ui: remote updates: show progress on 'refresh all' Dominik Csapak
2025-12-04 14:20 ` [pdm-devel] [PATCH datacenter-manager 3/5] ui: configuration: subscription: improve behavior on 'check' Dominik Csapak
2025-12-04 14:20 ` [pdm-devel] [PATCH datacenter-manager 4/5] ui: views: add message on empty layouts Dominik Csapak
2025-12-04 15:18   ` Lukas Wagner
2025-12-04 14:20 ` [pdm-devel] [RFC PATCH datacenter-manager 5/5] ui: main menu: use different icon for pbs remotes Dominik Csapak
2025-12-04 15:21   ` Lukas Wagner [this message]
2025-12-04 20:01   ` Thomas Lamprecht
2025-12-05  7:35     ` Dominik Csapak
2025-12-04 15:23 ` [pdm-devel] [PATCH datacenter-manager 0/5] some ui polishing changes Lukas Wagner
2025-12-04 20:01 ` [pdm-devel] partially-applied: " Thomas Lamprecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DEPJ96AUN14Q.2OF7305DE4SCM@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal