Re: [pdm-devel] [PATCH datacenter-manager 0/4] system report via admin cli or API

["Shannon Sterz" <s.sterz@proxmox.com>]

On Mon Dec 1, 2025 at 1:58 PM CET, Lukas Wagner wrote:
> Still missing the UI integration.
>
> Lukas Wagner (4):
>   server: add system report implementation
>   api: add system report API
>   cli: admin: add 'report' command to generate a system report
>   pdm-client: add bindings for system report generation
>
>  cli/admin/src/main.rs          |  13 +++
>  lib/pdm-client/src/lib.rs      |  10 ++
>  server/src/api/nodes/mod.rs    |   2 +
>  server/src/api/nodes/report.rs |  32 ++++++
>  server/src/lib.rs              |   1 +
>  server/src/report.rs           | 195 +++++++++++++++++++++++++++++++++
>  6 files changed, 253 insertions(+)
>  create mode 100644 server/src/api/nodes/report.rs
>  create mode 100644 server/src/report.rs

gave this a quick spin and looked through the code. as you mentioned in
one of the code comments at least parts of this should live in
proxmox-rs and share their implementation with proxmox-backup. however,
that shouldn't hold this up for now and can be done as a follow up.

left two minor comments on the first patch.

also tested this by building the manager binary and using it in my test
container. it worked as expected (some commands failed to this being a
testing container). so consider this:

Reviewed-by: Shannon Sterz <s.sterz@proxmox.com>
Tested-by: Shannon Sterz <s.sterz@proxmox.com>


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel