Re: [pdm-devel] [PATCH datacenter-manager 0/4] improve subscription display in

["Michael Köppl" <m.koeppl@proxmox.com>]

Quickly tested this by:
- adding a standalone host without a subscription
- adding a cluster without subscriptions
- adding a PBS instance
- mocking nodes with subscription to see if they are displayed correctly
- stopping nodes to see if connection errors are handled properly and
  errors are shown accordingly

Noticed that:
- If a PVE node goes offline, it is still displayed but will show an
  error message in the subscription tree. However, if a PBS instance
  goes offline, it simply disappears entirely from the tree.

Also had a look at the code and noted 1 nit on the individual patch.
Other than the issue noted above, the changes look good to me.

With the above issue addressed, consider this:
Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
Tested-by: Michael Köppl <m.koeppl@proxmox.com>

On Thu Nov 27, 2025 at 3:03 PM CET, Dominik Csapak wrote:
> add a force refresh button
> improve display of subscription details grid
>
> Dominik Csapak (4):
>   ui: dashboard: subscriptions: refactor subscriptions show logic
>   ui: dashboard: subscriptions list: update store when data changes
>   ui: dashboard: subscriptions list: improve display of subscription
>     state
>   ui: dashboard: subscriptions details: add a 'force refresh' button
>
>  ui/src/dashboard/subscription_info.rs  |  27 ++--
>  ui/src/dashboard/subscriptions_list.rs | 167 +++++++++++++++++--------
>  ui/src/dashboard/view.rs               |  51 +++++---
>  ui/src/load_result.rs                  |   6 +
>  4 files changed, 167 insertions(+), 84 deletions(-)



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel