[pdm-devel] [PATCH datacenter-manager 1/5] server: api: qemu: add pending api

[pdm-devel] [PATCH datacenter-manager 1/5] server: api: qemu: add pending api

[Dietmar Maurer]

Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
---
 server/src/api/pve/qemu.rs | 36 +++++++++++++++++++++++++++++++++++-
 1 file changed, 35 insertions(+), 1 deletion(-)

diff --git a/server/src/api/pve/qemu.rs b/server/src/api/pve/qemu.rs
index 4f144b7..effa7e5 100644
--- a/server/src/api/pve/qemu.rs
+++ b/server/src/api/pve/qemu.rs
@@ -14,7 +14,7 @@ use pdm_api_types::{
     PRIV_RESOURCE_MANAGE, PRIV_RESOURCE_MIGRATE, SNAPSHOT_NAME_SCHEMA, VMID_SCHEMA,
 };
 
-use pve_api_types::{QemuMigratePreconditions, StartQemuMigrationType};
+use pve_api_types::{PendingConfigValue, QemuMigratePreconditions, StartQemuMigrationType};
 
 use crate::api::pve::get_remote;
 
@@ -33,6 +33,7 @@ const QEMU_VM_ROUTER: Router = Router::new()
 #[sortable]
 const QEMU_VM_SUBDIRS: SubdirMap = &sorted!([
     ("config", &Router::new().get(&API_METHOD_QEMU_GET_CONFIG)),
+    ("pending", &Router::new().get(&API_METHOD_QEMU_GET_PENDING)),
     ("rrddata", &super::rrddata::QEMU_RRD_ROUTER),
     ("start", &Router::new().post(&API_METHOD_QEMU_START)),
     ("status", &Router::new().get(&API_METHOD_QEMU_GET_STATUS)),
@@ -152,6 +153,39 @@ pub async fn qemu_get_config(
         .await?)
 }
 
+#[api(
+    input: {
+        properties: {
+            remote: { schema: REMOTE_ID_SCHEMA },
+            node: {
+                schema: NODE_SCHEMA,
+                optional: true,
+            },
+            vmid: { schema: VMID_SCHEMA },
+        },
+    },
+    // Note: the trait `ApiType` is not implemented for `PendingConfigValue` because it contains Value
+    // returns: { description: "Configuration property with pending changes.", type: Array, items: { type: PendingConfigValue, }},
+    access: {
+        permission: &Permission::Privilege(&["resource", "{remote}", "guest", "{vmid}"], PRIV_RESOURCE_AUDIT, false),
+    },
+)]
+/// Get the pending configuration of a qemu VM from a remote. If a node is provided, the VM must be on that
+/// node, otherwise the node is determined automatically.
+pub async fn qemu_get_pending(
+    remote: String,
+    node: Option<String>,
+    vmid: u32,
+) -> Result<Vec<PendingConfigValue>, Error> {
+    let (remotes, _) = pdm_config::remotes::config()?;
+
+    let pve = connect_to_remote(&remotes, &remote)?;
+
+    let node = find_node_for_vm(node, vmid, pve.as_ref()).await?;
+
+    Ok(pve.qemu_get_pending(&node, vmid).await?)
+}
+
 #[api(
     input: {
         properties: {
-- 
2.47.3


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

[pdm-devel] [PATCH datacenter-manager 2/5] server: api: lxc: add pending api

[Dietmar Maurer]

Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
---
 server/src/api/pve/lxc.rs | 35 +++++++++++++++++++++++++++++++++++
 1 file changed, 35 insertions(+)

diff --git a/server/src/api/pve/lxc.rs b/server/src/api/pve/lxc.rs
index ecf0bef..3c27d24 100644
--- a/server/src/api/pve/lxc.rs
+++ b/server/src/api/pve/lxc.rs
@@ -7,6 +7,7 @@ use proxmox_router::{
 };
 use proxmox_schema::api;
 use proxmox_sortable_macro::sortable;
+use pve_api_types::PendingConfigValue;
 
 use pdm_api_types::remotes::REMOTE_ID_SCHEMA;
 use pdm_api_types::{
@@ -33,6 +34,7 @@ const LXC_VM_ROUTER: Router = Router::new()
 #[sortable]
 const LXC_VM_SUBDIRS: SubdirMap = &sorted!([
     ("config", &Router::new().get(&API_METHOD_LXC_GET_CONFIG)),
+    ("pending", &Router::new().get(&API_METHOD_LXC_GET_PENDING)),
     ("rrddata", &super::rrddata::LXC_RRD_ROUTER),
     ("start", &Router::new().post(&API_METHOD_LXC_START)),
     ("status", &Router::new().get(&API_METHOD_LXC_GET_STATUS)),
@@ -147,6 +149,39 @@ pub async fn lxc_get_config(
         .await?)
 }
 
+#[api(
+    input: {
+        properties: {
+            remote: { schema: REMOTE_ID_SCHEMA },
+            node: {
+                schema: NODE_SCHEMA,
+                optional: true,
+            },
+            vmid: { schema: VMID_SCHEMA },
+        },
+    },
+    // Note: the trait `ApiType` is not implemented for `PendingConfigValue` because it contains Value
+    // returns: { description: "Configuration property with pending changes.", type: Array, items: { type: PendingConfigValue, }},
+    access: {
+        permission: &Permission::Privilege(&["resource", "{remote}", "guest", "{vmid}"], PRIV_RESOURCE_AUDIT, false),
+    },
+)]
+/// Get the pending configuration of a lxc container from a remote. If a node is provided, the container must be on that
+/// node, otherwise the node is determined automatically.
+pub async fn lxc_get_pending(
+    remote: String,
+    node: Option<String>,
+    vmid: u32,
+) -> Result<Vec<PendingConfigValue>, Error> {
+    let (remotes, _) = pdm_config::remotes::config()?;
+
+    let pve = connect_to_remote(&remotes, &remote)?;
+
+    let node = find_node_for_vm(node, vmid, pve.as_ref()).await?;
+
+    Ok(pve.lxc_get_pending(&node, vmid).await?)
+}
+
 #[api(
     input: {
         properties: {
-- 
2.47.3


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

Re: [pdm-devel] [PATCH datacenter-manager 2/5] server: api: lxc: add pending api

[Lukas Wagner]

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Tested-by: Lukas Wagner <l.wagner@proxmox.com>


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

[pdm-devel] [PATCH datacenter-manager 3/5] ui: add cdrom icon

[Dietmar Maurer]

Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
---
 ui/css/pdm.scss             | 12 ++++++++++++
 ui/images/icon-cd-drive.svg | 26 ++++++++++++++++++++++++++
 2 files changed, 38 insertions(+)
 create mode 100644 ui/images/icon-cd-drive.svg

diff --git a/ui/css/pdm.scss b/ui/css/pdm.scss
index 71cd4b0..a15b4e8 100644
--- a/ui/css/pdm.scss
+++ b/ui/css/pdm.scss
@@ -57,6 +57,17 @@
     display: inline-block;
 }
 
+.fa-cdrom::before {
+    content: " ";
+    background-image: url(./images/icon-cd-drive.svg);
+    background-size: 16px 16px;
+    background-repeat: no-repeat;
+    width: 16px;
+    height: 16px;
+    vertical-align: bottom;
+    display: inline-block;
+}
+
 .fa-sdn-vnet::before {
     content: " ";
     mask-image: url(./images/icon-sdn-vnet.svg);
@@ -96,6 +107,7 @@
 }
 
 :root.pwt-dark-mode {
+    .fa-cdrom,
     .fa-memory,
     .fa-cpu {
         filter: invert(90%);
diff --git a/ui/images/icon-cd-drive.svg b/ui/images/icon-cd-drive.svg
new file mode 100644
index 0000000..6ee7184
--- /dev/null
+++ b/ui/images/icon-cd-drive.svg
@@ -0,0 +1,26 @@
+<?xml version="1.0" encoding="UTF-8" standalone="no"?>
+<svg
+    xmlns:rdf="http://www.w3.org/1999/02/22-rdf-syntax-ns#"
+    xmlns:svg="http://www.w3.org/2000/svg"
+    xmlns="http://www.w3.org/2000/svg"
+    width="100"
+    height="100"
+    version="1.1"
+>
+    <style type="text/css">
+        path, .outline { fill: none; stroke: #000; }
+        .filled { fill: #000; stroke: #000; }
+    /* handled over an outer CSS filter as WebKit / Safari do not inherit the context over SVG
+     * image boundary even though that's accepted by the w3c CSSWG...
+     *  @media (prefers-color-scheme: dark) {
+     *      path, .outline { fill: none; stroke: #fff; }
+     *      .filled { fill: #fff; stroke: #fff; }
+     *  }
+     **/
+    </style>
+
+    <g class="outline" stroke-width="8">
+        <circle cx="50" cy="50" r="45"/>
+        <circle cx="50" cy="50" r="15"/>
+    </g>
+</svg>
-- 
2.47.3


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

Re: [pdm-devel] [PATCH datacenter-manager 3/5] ui: add cdrom icon

[Lukas Wagner]

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Tested-by: Lukas Wagner <l.wagner@proxmox.com>


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

[pdm-devel] [PATCH datacenter-manager 4/5] ui: add qemu Hardware and Options panel

[Dietmar Maurer]

Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
---
 ui/src/pve/qemu/mod.rs | 36 ++++++++++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)

diff --git a/ui/src/pve/qemu/mod.rs b/ui/src/pve/qemu/mod.rs
index c666f7e..ba35c2c 100644
--- a/ui/src/pve/qemu/mod.rs
+++ b/ui/src/pve/qemu/mod.rs
@@ -8,6 +8,8 @@ use yew::virtual_dom::{VComp, VNode};
 use pwt::prelude::*;
 use pwt::widget::{Fa, Row, TabBarItem, TabPanel};
 
+use proxmox_yew_comp::configuration::pve::{QemuHardwarePanel, QemuOptionsPanel};
+
 use pdm_api_types::resource::PveQemuResource;
 
 use crate::pve::utils::render_qemu_name;
@@ -70,6 +72,40 @@ impl yew::Component for QemuPanelComp {
                     }
                 },
             )
+            .with_item_builder(
+                TabBarItem::new()
+                    .key("hardware")
+                    .label(tr!("Hardware"))
+                    .icon_class("fa fa-desktop"),
+                {
+                    let remote = props.remote.clone();
+                    let node = props.node.clone();
+                    let vmid = props.info.vmid;
+                    move |_| {
+                        QemuHardwarePanel::new(node.clone(), vmid)
+                            .readonly(true)
+                            .remote(remote.clone())
+                            .into()
+                    }
+                },
+            )
+            .with_item_builder(
+                TabBarItem::new()
+                    .key("options")
+                    .label(tr!("Options"))
+                    .icon_class("fa fa-gear"),
+                {
+                    let remote = props.remote.clone();
+                    let node = props.node.clone();
+                    let vmid = props.info.vmid;
+                    move |_| {
+                        QemuOptionsPanel::new(node.clone(), vmid)
+                            .readonly(true)
+                            .remote(remote.clone())
+                            .into()
+                    }
+                },
+            )
             .into()
     }
 }
-- 
2.47.3


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

Re: [pdm-devel] [PATCH datacenter-manager 4/5] ui: add qemu Hardware and Options panel

[Lukas Wagner]

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Tested-by: Lukas Wagner <.lwagner@proxmox.com>


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

[pdm-devel] [PATCH datacenter-manager 5/5] ui: add lxc resources, network, dns and options panels

[Dietmar Maurer]

With read-only mode.

Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
---
 ui/src/pve/lxc/mod.rs | 71 +++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 71 insertions(+)

diff --git a/ui/src/pve/lxc/mod.rs b/ui/src/pve/lxc/mod.rs
index dae6514..8dda5d6 100644
--- a/ui/src/pve/lxc/mod.rs
+++ b/ui/src/pve/lxc/mod.rs
@@ -1,5 +1,8 @@
 mod overview;
 use overview::LxcOverviewPanel;
+use proxmox_yew_comp::configuration::pve::{
+    LxcDnsPanel, LxcNetworkPanel, LxcOptionsPanel, LxcResourcesPanel,
+};
 
 use std::rc::Rc;
 
@@ -70,6 +73,74 @@ impl yew::Component for LxcPanelComp {
                     }
                 },
             )
+            .with_item_builder(
+                TabBarItem::new()
+                    .key("resources")
+                    .label(tr!("Resources"))
+                    .icon_class("fa fa-cube"),
+                {
+                    let remote = props.remote.clone();
+                    let node = props.node.clone();
+                    let vmid = props.info.vmid;
+                    move |_| {
+                        LxcResourcesPanel::new(node.clone(), vmid)
+                            .readonly(true)
+                            .remote(remote.clone())
+                            .into()
+                    }
+                },
+            )
+            .with_item_builder(
+                TabBarItem::new()
+                    .key("network")
+                    .label(tr!("Network"))
+                    .icon_class("fa fa-exchange"),
+                {
+                    let remote = props.remote.clone();
+                    let node = props.node.clone();
+                    let vmid = props.info.vmid;
+                    move |_| {
+                        LxcNetworkPanel::new(node.clone(), vmid)
+                            .readonly(true)
+                            .remote(remote.clone())
+                            .into()
+                    }
+                },
+            )
+            .with_item_builder(
+                TabBarItem::new()
+                    .key("dns")
+                    .label(tr!("DNS"))
+                    .icon_class("fa fa-globe"),
+                {
+                    let remote = props.remote.clone();
+                    let node = props.node.clone();
+                    let vmid = props.info.vmid;
+                    move |_| {
+                        LxcDnsPanel::new(node.clone(), vmid)
+                            .readonly(true)
+                            .remote(remote.clone())
+                            .into()
+                    }
+                },
+            )
+            .with_item_builder(
+                TabBarItem::new()
+                    .key("options")
+                    .label(tr!("Options"))
+                    .icon_class("fa fa-gear"),
+                {
+                    let remote = props.remote.clone();
+                    let node = props.node.clone();
+                    let vmid = props.info.vmid;
+                    move |_| {
+                        LxcOptionsPanel::new(node.clone(), vmid)
+                            .readonly(true)
+                            .remote(remote.clone())
+                            .into()
+                    }
+                },
+            )
             .into()
     }
 }
-- 
2.47.3


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

Re: [pdm-devel] [PATCH datacenter-manager 5/5] ui: add lxc resources, network, dns and options panels

[Lukas Wagner]

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Tested-by: Lukas Wagner <.lwagner@proxmox.com>


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

Re: [pdm-devel] [PATCH datacenter-manager 1/5] server: api: qemu: add pending api

[Lukas Wagner]

Looks good to me; also seems to work as expected.

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>
Tested-by: Lukas Wagner <l.wagner@proxmox.com>


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

Re: [pdm-devel] [PATCH datacenter-manager 1/5] server: api: qemu: add pending api

[Thomas Lamprecht]

On Thu, 27 Nov 2025 12:34:24 +0100, Dietmar Maurer wrote:
> 


Applied, thanks!

FYI: I merged the different tabs into a single one in follow-up commits though,
IMO thats a bit better fitting for the PDM layout for virtual guests and
especially for CTs the four tabs were a bit much (given that at least firewall
and backup will be added in the future).

[1/5] server: api: qemu: add pending api
      commit: 177c75348e73815083aeda4b222cffe26c4e1db1
[2/5] server: api: lxc: add pending api
      commit: db0154293d1277ab3a4d879bce1bd6d9f5727bf3
[3/5] ui: add cdrom icon
      commit: 9e178696fcaf0a62233f0ac476847e5ae3046827
[4/5] ui: add qemu Hardware and Options panel
      commit: ecea09b1356f1ac63b28cc6741464fbd2f7f3041
[5/5] ui: add lxc resources, network, dns and options panels
      commit: 74c66ea6f087c90e6d5fb3fcc4c5456abc0618f2


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel