From: "Michael Köppl" <m.koeppl@proxmox.com>
To: "Hannes Laimer" <h.laimer@proxmox.com>,
"Proxmox Datacenter Manager development discussion"
<pdm-devel@lists.proxmox.com>,
"Michael Köppl" <m.koeppl@proxmox.com>
Cc: pdm-devel <pdm-devel-bounces@lists.proxmox.com>
Subject: Re: [pdm-devel] [PATCH proxmox{, -yew-comp, -datacenter-manager} v4 00/12] add basic integration of PVE firewall
Date: Thu, 27 Nov 2025 10:23:09 +0100 [thread overview]
Message-ID: <DEJD91D7IC1X.2TP77N6WPREHW@proxmox.com> (raw)
In-Reply-To: <950473aa-7a29-4f21-8ec2-bed5cd924c18@proxmox.com>
On Thu Nov 27, 2025 at 9:49 AM CET, Hannes Laimer wrote:
>> - It was not entirely clear to me what the Filter field was for. FWICT
>> based on the implementation it only filters guests? Is that on
>> purpose?
> yes, we do the same in the resource tree of a cluster, removing
> node/cluster entries from the tree would lead to potentially odd
> tree structures
From a user perspective I thought it would help if the hint said
something like "Filter guests" or "Filter VMID". IMO this would make
sense for the resource tree as well, but that's out
of scope for this series anyway, just wanted to note it here.
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-11-27 9:23 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-20 12:55 Hannes Laimer
2025-11-20 12:55 ` [pdm-devel] [PATCH proxmox v4 1/4] pve-api-types: update pve-api.json Hannes Laimer
2025-11-20 12:55 ` [pdm-devel] [PATCH proxmox v4 2/4] pve-api-types: add get/update firewall options endpoints Hannes Laimer
2025-11-20 12:55 ` [pdm-devel] [PATCH proxmox v4 3/4] pve-api-types: add list firewall rules endpoints Hannes Laimer
2025-11-20 12:55 ` [pdm-devel] [PATCH proxmox v4 4/4] pve-api-types: regenerate Hannes Laimer
2025-11-20 12:55 ` [pdm-devel] [PATCH proxmox-yew-comp v4 1/4] form: add helpers for extractig data out of schemas Hannes Laimer
2025-11-20 12:55 ` [pdm-devel] [PATCH proxmox-yew-comp v4 2/4] firewall: add FirewallContext Hannes Laimer
2025-11-20 12:55 ` [pdm-devel] [PATCH proxmox-yew-comp v4 3/4] firewall: add options edit form Hannes Laimer
2025-11-20 12:55 ` [pdm-devel] [PATCH proxmox-yew-comp v4 4/4] firewall: add rules table Hannes Laimer
2025-11-20 12:55 ` [pdm-devel] [PATCH proxmox-datacenter-manager v4 1/4] pdm-api-types: add firewall status types Hannes Laimer
2025-11-20 12:55 ` [pdm-devel] [PATCH proxmox-datacenter-manager v4 2/4] api: firewall: add option, rules and status endpoints Hannes Laimer
2025-11-20 12:55 ` [pdm-devel] [PATCH proxmox-datacenter-manager v4 3/4] pdm-client: add api methods for firewall options, " Hannes Laimer
2025-11-20 12:55 ` [pdm-devel] [PATCH proxmox-datacenter-manager v4 4/4] ui: add firewall status tree Hannes Laimer
2025-11-21 11:09 ` [pdm-devel] [PATCH proxmox{, -yew-comp, -datacenter-manager} v4 00/12] add basic integration of PVE firewall Stefan Hanreich
2025-11-26 14:51 ` Michael Köppl
2025-11-27 8:49 ` Hannes Laimer
2025-11-27 9:23 ` Michael Köppl [this message]
2025-11-27 9:24 ` [pdm-devel] superseded: " Hannes Laimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DEJD91D7IC1X.2TP77N6WPREHW@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=h.laimer@proxmox.com \
--cc=pdm-devel-bounces@lists.proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox