Re: [pdm-devel] [PATCH datacenter-manager v3 06/18] ui: dashboard types: add missing 'default' to de-serialization

From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>
Cc: Proxmox Datacenter Manager development discussion
	<pdm-devel@lists.proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager v3 06/18] ui: dashboard types: add missing 'default' to de-serialization
Date: Mon, 17 Nov 2025 15:59:01 +0100	[thread overview]
Message-ID: <DEB24QL8CJLK.2BH9HVZ0VSRJQ@proxmox.com> (raw)
In-Reply-To: <20251117125041.1931382-7-d.csapak@proxmox.com>

On Mon Nov 17, 2025 at 1:44 PM CET, Dominik Csapak wrote:
> otherwise a layout with now rows can be serialized, but not

nit: typo, now -> no rows

> deserialized.
>
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
>  ui/src/dashboard/types.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/src/dashboard/types.rs b/ui/src/dashboard/types.rs
> index c79c38ab..3b018b6e 100644
> --- a/ui/src/dashboard/types.rs
> +++ b/ui/src/dashboard/types.rs
> @@ -17,7 +17,7 @@ pub struct ViewTemplate {
>  #[serde(tag = "layout-type")]
>  pub enum ViewLayout {
>      Rows {
> -        #[serde(skip_serializing_if = "Vec::is_empty")]
> +        #[serde(default, skip_serializing_if = "Vec::is_empty")]
>          rows: Vec<Vec<RowWidget>>,
>      },
>  }


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel