From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
<pdm-devel@lists.proxmox.com>
Subject: Re: [pdm-devel] applied: [PATCH datacenter-manager v3] fix #6797: ui: add dialog to view remote subscriptions
Date: Fri, 14 Nov 2025 14:37:09 +0100 [thread overview]
Message-ID: <DE8GIFE6ZAHR.P97B4ULFG9P0@proxmox.com> (raw)
In-Reply-To: <176306675312.2716498.8590631456222157754.b4-ty@proxmox.com>
On Thu Nov 13, 2025 at 9:45 PM CET, Thomas Lamprecht wrote:
> On Wed, 05 Nov 2025 13:45:05 +0100, Shan Shaji wrote:
>> When clicking on the subscription status panel, no details appeared that
>> will help the user to see the subscription details of remote/nodes. For
>> example if a remote had a "mixed" subscription state, users couldn't see
>> which remote had that state.
>>
>> Fixed the issue by adding a subscription dialog. Now, when the users
>> click the subscription status panel, a dialog opens showing the remote
>> subscription state and the individual subscriptions for each node.
>>
>> [...]
>
> Applied, thanks!
>
> As future improvements it might be nice to:
> - show single-node remotes directly without having to expand a tree node, i.e.
> similar to what Lukas did for the Remotes -> Updates view.
> - Allow filtering/searching
> - Show a red error like icon if there is no subscription.
Thanks Thomas for the feedback. Will update this accordingly. For now i
will send a quick fix for the dialog opening when clicking on the link (www.proxmox.com).
> In the midterm we could also add this as panel in the Remotes tab.
> And it might be actually OK to have this as "real" card widget in the
> dashboard, i.e. either as dedicated one, or fusing it into the existing
> subscription card - @Dominik might have an opinion here too.
Will talk with Domink about this one. Thank You!
> [1/1] fix #6797: ui: add dialog to view remote subscriptions
> commit: 6140069b955fff8c5157b9d820292995c6053011
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
prev parent reply other threads:[~2025-11-14 13:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-05 12:45 [pdm-devel] " Shan Shaji
2025-11-13 20:45 ` [pdm-devel] applied: " Thomas Lamprecht
2025-11-14 13:37 ` Shan Shaji [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DE8GIFE6ZAHR.P97B4ULFG9P0@proxmox.com \
--to=s.shaji@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox