From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Lukas Wagner" <l.wagner@proxmox.com>
Cc: Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager v3 1/3] server/api-types: move AccessControlConfig to shared api types
Date: Thu, 13 Nov 2025 11:23:55 +0100 [thread overview]
Message-ID: <DE7HRXNXUDX7.2CMXKG85DHU90@proxmox.com> (raw)
In-Reply-To: <DE7HLQDABZAQ.1ORU4DT2X1OLE@proxmox.com>
On Thu Nov 13, 2025 at 11:15 AM CET, Lukas Wagner wrote:
> On Thu Nov 6, 2025 at 3:38 PM CET, Shannon Sterz wrote:
>> this doesn't really contain any information that is secret. moving it
>> to the shared api types allows re-using it in the ui to check what
>> privileges a user needs to access certain features.
>>
>
> I'm not sure if pdm-api-types is the correct place for this, since it
> does not really contain any... well... API types, as far as I can tell
> :)
>
> Maybe this should be in `lib/pdm-ui-shared` or it's own small
> micro-crate under `lib/`? What do you think?
well my thinking was that we already define all privileges and roles
here. keeping all of that in one place made sense to me, especially
because roles and privileges aren't "types" in the traditional sense,
but rather constants. so if we move that out, i'd like to move the roles
and privileges etc. too. but i have no hard feelings on whether these
stay here or get moved somewhere else and re-exported here.
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-11-13 10:23 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-06 14:38 [pdm-devel] [PATCH datacenter-manager/proxmox/yew-comp v3 00/10] add support for checking acl permissions in (yew) front-ends Shannon Sterz
2025-11-06 14:38 ` [pdm-devel] [PATCH proxmox v3 1/5] access-control: add acl feature to only expose types and the AclTree Shannon Sterz
2025-11-06 14:38 ` [pdm-devel] [PATCH proxmox v3 2/5] access-control: use format strings where possible Shannon Sterz
2025-11-06 14:38 ` [pdm-devel] [PATCH proxmox v3 3/5] access-control: move functions querying privileges to the AclTree Shannon Sterz
2025-11-06 14:38 ` [pdm-devel] [PATCH proxmox v3 4/5] access-control: derive Debug and PartialEq on AclTree and AclTreeNode Shannon Sterz
2025-11-06 14:38 ` [pdm-devel] [PATCH proxmox v3 5/5] access-control: allow reading all acls of the current authid Shannon Sterz
2025-11-13 10:23 ` Lukas Wagner
2025-11-06 14:38 ` [pdm-devel] [PATCH yew-comp v3 1/2] acl_context: add AclContext and AclContextProvider Shannon Sterz
2025-11-06 14:38 ` [pdm-devel] [PATCH yew-comp v3 2/2] http_helpers: reload LocalAclTree when logging in or refreshing a ticket Shannon Sterz
2025-11-06 14:38 ` [pdm-devel] [PATCH datacenter-manager v3 1/3] server/api-types: move AccessControlConfig to shared api types Shannon Sterz
2025-11-13 10:15 ` Lukas Wagner
2025-11-13 10:23 ` Shannon Sterz [this message]
2025-11-06 14:38 ` [pdm-devel] [PATCH datacenter-manager v3 2/3] ui: add an AclContext via the AclContextProvider to the main app ui Shannon Sterz
2025-11-06 14:38 ` [pdm-devel] [PATCH datacenter-manager v3 3/3] ui: main menu: use the AclContext to hide the Notes if appropriate Shannon Sterz
2025-11-13 10:21 ` [pdm-devel] [PATCH datacenter-manager/proxmox/yew-comp v3 00/10] add support for checking acl permissions in (yew) front-ends Lukas Wagner
2025-11-13 10:26 ` Shannon Sterz
2025-11-13 13:58 ` Fabian Grünbichler
2025-11-13 14:27 ` Shannon Sterz
2025-11-13 16:18 ` Thomas Lamprecht
2025-11-13 16:39 ` Shannon Sterz
2025-11-13 17:06 ` Thomas Lamprecht
2025-11-14 14:44 ` [pdm-devel] Superseded: " Shannon Sterz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DE7HRXNXUDX7.2CMXKG85DHU90@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox