Re: [pdm-devel] [PATCH proxmox-datacenter-manager v3 4/4] ui: add firewall status tree

From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox Datacenter Manager development discussion"
	<pdm-devel@lists.proxmox.com>,
	"Stefan Hanreich" <s.hanreich@proxmox.com>
Subject: Re: [pdm-devel] [PATCH proxmox-datacenter-manager v3 4/4] ui: add firewall status tree
Date: Wed, 12 Nov 2025 15:41:47 +0100	[thread overview]
Message-ID: <DE6SMTQKYJLR.2ARZLSFDXBR3T@proxmox.com> (raw)
In-Reply-To: <82ed4e5a-1fef-42cb-930c-6464f9e10aad@proxmox.com>

On Wed Nov 12, 2025 at 12:21 PM CET, Stefan Hanreich wrote:
>> +
>> +fn sort_entries(a: &TreeEntry, b: &TreeEntry) -> Ordering {
>> +    let rank_a = a.sort_rank();
>> +    let rank_b = b.sort_rank();
>> +    match rank_a.cmp(&rank_b) {
>> +        Ordering::Equal => a.name().cmp(&b.name()),
>> +        other => other,
>> +    }
>> +}
>
> maybe (a.sort_rank(), a.name()).cmp(&(b.sort_rank(), b.name())), makes
> the intention clearer imo - or is a.name() expensive?
>

I would contest the claim that it's clearer, I actually had to look up
how .cmp works for tuples just now, TIL! :D

But it's more elegant and shorter, that's for sure.

_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel