public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Michael Köppl" <m.koeppl@proxmox.com>
To: "Proxmox Datacenter Manager development discussion"
	<pdm-devel@lists.proxmox.com>
Cc: "pdm-devel" <pdm-devel-bounces@lists.proxmox.com>
Subject: Re: [pdm-devel] [PATCH proxmox-yew-comp v2 3/4] firewall: add options edit form
Date: Mon, 10 Nov 2025 13:36:56 +0100	[thread overview]
Message-ID: <DE50Q58RLCSH.1ATIF8HNXNPMV@proxmox.com> (raw)
In-Reply-To: <20251105163546.450094-8-h.laimer@proxmox.com>

On Wed Nov 5, 2025 at 5:35 PM CET, Hannes Laimer wrote:
> +    fn changed(&mut self, ctx: &yew::Context<Self>, _old_props: &Self::Properties) -> bool {
> +        self.parse_value(&ctx.props().value);
> +        true
> +    }
> +
> +    fn view(&self, ctx: &yew::Context<Self>) -> Html {
> +        let is_empty = self.number.is_none();
> +        let number_value = self.number.map(|n| n.to_string()).unwrap_or_default();
> +
> +        let units: Vec<AttrValue> = TIME_UNITS.iter().map(|&u| AttrValue::from(u)).collect();
> +
> +        Row::new()
> +            .style("align-items", "center")
> +            .gap(1)
> +            .with_child(
> +                Number::<u64>::new()
> +                    .key("rate_number")
> +                    .value(number_value)
> +                    .placeholder("1")
> +                    .min(1)

This should probably also have a .max(99), since in PVE we don't allow
setting values greater than 99.

> +                    .on_change(ctx.link().callback(|result: Option<Result<u64, String>>| {
> +                        RateMsg::ChangeNumber(result.and_then(|r| r.ok()))
> +                    })),
> +            )
> +            .with_child("/")



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  parent reply	other threads:[~2025-11-10 12:36 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-05 16:35 [pdm-devel] [PATCH proxmox{, -yew-comp, -datacenter-manager} v2 00/12] add basic integration of PVE firewall Hannes Laimer
2025-11-05 16:35 ` [pdm-devel] [PATCH proxmox v2 1/4] pve-api-types: update pve-api.json Hannes Laimer
2025-11-05 16:35 ` [pdm-devel] [PATCH proxmox v2 2/4] pve-api-types: add get/update firewall options endpoints Hannes Laimer
2025-11-05 16:35 ` [pdm-devel] [PATCH proxmox v2 3/4] pve-api-types: add list firewall rules endpoints Hannes Laimer
2025-11-05 16:35 ` [pdm-devel] [PATCH proxmox v2 4/4] pve-api-types: regenerate Hannes Laimer
2025-11-10 13:47   ` Michael Köppl
2025-11-10 14:04     ` Hannes Laimer
2025-11-10 15:25   ` Michael Köppl
2025-11-10 15:33     ` Hannes Laimer
2025-11-10 15:40       ` Hannes Laimer
2025-11-10 15:47       ` Michael Köppl
2025-11-05 16:35 ` [pdm-devel] [PATCH proxmox-yew-comp v2 1/4] form: add helpers for extractig data out of schemas Hannes Laimer
2025-11-05 16:35 ` [pdm-devel] [PATCH proxmox-yew-comp v2 2/4] firewall: add FirewallContext Hannes Laimer
2025-11-05 16:35 ` [pdm-devel] [PATCH proxmox-yew-comp v2 3/4] firewall: add options edit form Hannes Laimer
2025-11-07 12:26   ` Lukas Wagner
2025-11-10 12:36   ` Michael Köppl [this message]
2025-11-05 16:35 ` [pdm-devel] [PATCH proxmox-yew-comp v2 4/4] firewall: add rules table Hannes Laimer
2025-11-07 12:26   ` Lukas Wagner
2025-11-10 14:51     ` Hannes Laimer
2025-11-05 16:35 ` [pdm-devel] [PATCH proxmox-datacenter-manager v2 1/4] pdm-api-types: add firewall status types Hannes Laimer
2025-11-07 12:27   ` Lukas Wagner
2025-11-05 16:35 ` [pdm-devel] [PATCH proxmox-datacenter-manager v2 2/4] api: firewall: add option, rules and status endpoints Hannes Laimer
2025-11-06 16:58   ` Michael Köppl
2025-11-07  6:43     ` Hannes Laimer
2025-11-07 12:27   ` Lukas Wagner
2025-11-10 14:56     ` Hannes Laimer
2025-11-05 16:35 ` [pdm-devel] [PATCH proxmox-datacenter-manager v2 3/4] pdm-client: add api methods for firewall options, " Hannes Laimer
2025-11-05 16:35 ` [pdm-devel] [PATCH proxmox-datacenter-manager v2 4/4] ui: add firewall status tree Hannes Laimer
2025-11-07 12:27   ` Lukas Wagner
2025-11-10 15:29     ` Hannes Laimer
2025-11-10 17:26 ` [pdm-devel] superseded: [PATCH proxmox{, -yew-comp, -datacenter-manager} v2 00/12] add basic integration of PVE firewall Hannes Laimer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DE50Q58RLCSH.1ATIF8HNXNPMV@proxmox.com \
    --to=m.koeppl@proxmox.com \
    --cc=pdm-devel-bounces@lists.proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal