Re: [pdm-devel] [PATCH datacenter-manager/proxmox/yew-comp 0/6] add node status panel to proxmox datacenter manager

["Shannon Sterz" <s.sterz@proxmox.com>]

On Mon Nov 3, 2025 at 2:15 PM CET, Dominik Csapak wrote:
> One high level comment:
>
> Since it is a panel with tools, etc. it looks a bit weird
> in the tab panel due to it being just one element
>
> It'll look better when we add the RRD graphs of the node
> (when we have that), since then it looks more like the other
> places where we have panels.

yes which is why i send that commit as an rfc. imo, it would make sense
to turn this into a widget one can use for a view once that feature is
applied. should be fairly straight forward, what do you think?

> Other than that and the few nits and one issue i commented,
> consider this series:

adapted the nits, since none of them changed anything substantial, i'll
keep your trailers for a v2, hope that alright.

> Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
> Tested-by: Dominik Csapak <d.csapak@proxmox.com>
>
> On 10/28/25 5:45 PM, Shannon Sterz wrote:
>> this series adds a node status panel to the administration menu of
>> proxmox datacenter manager. it allows for getting a rough overview of
>> system load as well as accessing the node's fingerprint and rebooting
>> and powering off the node.
>>
>> the fist patch moves the api endpoints from proxmox-backup server to
>> their own proxmox-rs crate. the next two commits extend yew-comp to
>> allow implementing a node status panel of the newly extracted api
>> endpoints return types.
>>
>> the next three commits first add the new api endpoints to proxmox
>> datacenter manager, add the ui panel to the Administration menu and
>> remove a suproflous macro.
>>
>> the last two commits are sent as RFC, as i am not sure whether we want
>> to have the panel in that menu or should maybe treat it as a widget for
>> the new view feature. while the last commit is just a clean up
>> suggestion i came accross while implementing this.
>>
>> proxmox:
>>
>> Shannon Sterz (1):
>>    node-status: add node status crate
>>
>>   Cargo.toml                               |   1 +
>>   proxmox-node-status/Cargo.toml           |  37 +++++
>>   proxmox-node-status/debian/changelog     |   5 +
>>   proxmox-node-status/debian/control       |  65 ++++++++
>>   proxmox-node-status/debian/copyright     |  18 +++
>>   proxmox-node-status/debian/debcargo.toml |   7 +
>>   proxmox-node-status/src/api.rs           | 184 +++++++++++++++++++++++
>>   proxmox-node-status/src/lib.rs           |  11 ++
>>   proxmox-node-status/src/types.rs         | 184 +++++++++++++++++++++++
>>   9 files changed, 512 insertions(+)
>>   create mode 100644 proxmox-node-status/Cargo.toml
>>   create mode 100644 proxmox-node-status/debian/changelog
>>   create mode 100644 proxmox-node-status/debian/control
>>   create mode 100644 proxmox-node-status/debian/copyright
>>   create mode 100644 proxmox-node-status/debian/debcargo.toml
>>   create mode 100644 proxmox-node-status/src/api.rs
>>   create mode 100644 proxmox-node-status/src/lib.rs
>>   create mode 100644 proxmox-node-status/src/types.rs
>>
>>
>> proxmox-yew-comp:
>>
>> Shannon Sterz (2):
>>    node info: extend NodeStatus enum to include NodeStatus from
>>      proxmox-rs
>>    node status panel: add a panel that show the current status of a node
>>
>>   Cargo.toml               |   1 +
>>   src/lib.rs               |   3 +
>>   src/node_info.rs         |  38 ++++++
>>   src/node_status_panel.rs | 244 +++++++++++++++++++++++++++++++++++++++
>>   4 files changed, 286 insertions(+)
>>   create mode 100644 src/node_status_panel.rs
>>
>>
>> proxmox-datacenter-manager:
>>
>> Shannon Sterz (3):
>>    api-types/api: add endpoints for querying the node's status
>>    ui: add NodeStatusPanel to the administration menu
>>    nodes: remove unnecessary rustfmt::skip macro
>>
>>   Cargo.toml                                    |  2 ++
>>   lib/pdm-api-types/src/acl.rs                  |  2 ++
>>   server/Cargo.toml                             |  1 +
>>   server/src/api/nodes/mod.rs                   |  3 ++-
>>   server/src/api/nodes/status.rs                | 18 ++++++++++++++++++
>>   server/src/bin/proxmox-datacenter-api/main.rs |  2 ++
>>   ui/src/administration/mod.rs                  | 15 ++++++++++++++-
>>   7 files changed, 41 insertions(+), 2 deletions(-)
>>   create mode 100644 server/src/api/nodes/status.rs
>>
>>
>> Summary over all repositories:
>>    20 files changed, 839 insertions(+), 2 deletions(-)
>>
>> --
>> Generated by git-murpp 0.8.1
>>
>>
>> _______________________________________________
>> pdm-devel mailing list
>> pdm-devel@lists.proxmox.com
>> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
>>
>>



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel