From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Shan Shaji" <s.shaji@proxmox.com>,
"Proxmox Datacenter Manager development discussion"
<pdm-devel@lists.proxmox.com>
Cc: pdm-devel <pdm-devel-bounces@lists.proxmox.com>
Subject: Re: [pdm-devel] [PATCH proxmox{, -datacenter-manager} 0/4] show dedicated datastore icons in tree view and removable/s3 backend info in overview
Date: Wed, 05 Nov 2025 17:26:20 +0100 [thread overview]
Message-ID: <DE0WH1YK1XUC.3I5YLP24WTB1R@proxmox.com> (raw)
In-Reply-To: <DE0VX04TN4E8.1YYAZ0E6MN8ZS@proxmox.com>
I have gone through the code and the changes looks fine. However, it
would be good to have another review as well.
Reviewed-by: Shan Shaji <s.shaji@proxmox.com>
On Wed Nov 5, 2025 at 5:00 PM CET, Shan Shaji wrote:
> Applied this patch series and verified the following:
>
> - Added a backup server to PDM.
> - Added local, removable, and S3 datastores(cloudflare r2)
> to the backup server.
> - Verified that the icons are displayed correctly
> in both the tree view and the overview section.
> - Confirmed that the icons differ based on the datastore type.
> - For the S3 datastore, the endpoint ID is visible in
> the overview section, and for the removable device, the
> UUID is shown.
>
> Tested-by: Shan Shaji <s.shaji@proxmox.com>
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
prev parent reply other threads:[~2025-11-05 16:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-04 14:49 Christian Ebner
2025-11-04 14:49 ` [pdm-devel] [PATCH proxmox 1/1] pbs-api-types: extend datastore config by backend config parser helper Christian Ebner
2025-11-04 14:49 ` [pdm-devel] [PATCH proxmox-datacenter-manager 1/3] ui: indicate removable datastore in overview and show backing device Christian Ebner
2025-11-04 14:49 ` [pdm-devel] [PATCH proxmox-datacenter-manager 2/3] ui: indicate s3 datastores in overview and show endpoint id Christian Ebner
2025-11-04 14:49 ` [pdm-devel] [PATCH proxmox-datacenter-manager 3/3] ui: datastore tree: indicate datastore type by different icons Christian Ebner
2025-11-05 16:00 ` [pdm-devel] [PATCH proxmox{, -datacenter-manager} 0/4] show dedicated datastore icons in tree view and removable/s3 backend info in overview Shan Shaji
2025-11-05 16:26 ` Shan Shaji [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DE0WH1YK1XUC.3I5YLP24WTB1R@proxmox.com \
--to=s.shaji@proxmox.com \
--cc=pdm-devel-bounces@lists.proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox