Re: [pdm-devel] [PATCH datacenter-manager v2 02/12] pdm-config: views: add support for view-filters

["Lukas Wagner" <l.wagner@proxmox.com>]

On Wed Nov 5, 2025 at 11:07 AM CET, Dominik Csapak wrote:
> high level comments:
>
> would it be nicer if we use the ApiSectionDataEntry trait like we do for 
> Remotes ?

Wasn't aware of this trait - will change it accordingly. Thanks!

> that way we can use the typed section config helpers
> (which are a bit more ergonomic to use later in the CRUD api calls)
>
> Also if we just use one file for the views, is it necessary
> to put it in a views folder?

Yeah, the structure was chosen due to the initial idea of separating the
filter definition and the view template.

>
> I'm currently thinking about how to save the layouts, and (as we 
> recently discussed off-list) I'm leaning towards simply saving the
> layout as a json string into the config here, as that makes the
> loading/saving/updating/deleting much easier for both view filters
> and layouts (no need to track/lock both configs, etc.)
>
> We can of course leave it , but then we have to make sure to create
> the directory correctly :)
>

I have no hard feelings about this. Generally I'm fine with saving the
template-JSON data directly into this struct (we can still extend it
with 'externally' defined templates later and introduce a new key that
just contains the ID of that).

If we pack everthing into one struct, I'd probably rename it from
ViewFilter to just View (same for the API parameters).

So, for v3 I'd just do a plain `views.cfg` in the top-level config
dir.


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel