From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox Datacenter Manager development discussion"
<pdm-devel@lists.proxmox.com>,
"Christian Ebner" <c.ebner@proxmox.com>
Subject: [pdm-devel] applied: [PATCH datacenter-manager] ui: pbs datastores panel: make status label translatable
Date: Mon, 03 Nov 2025 14:16:52 +0100 [thread overview]
Message-ID: <DDZ36WM67GLX.1RMTW81Y1JO61@proxmox.com> (raw)
In-Reply-To: <20251103130039.384294-1-c.ebner@proxmox.com>
On Mon Nov 3, 2025 at 2:00 PM CET, Christian Ebner wrote:
> The shown labels must be translatable to other languages. This has
> been overlooked in the initial implementation introduced by commit
> 2dcae341 ("ui: dashboard: add panel for PBS datastore statistics").
>
> Reported-by: Shannon Sterz <s.sterz@proxmox.com>
> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
> ---
> ui/src/dashboard/pbs_datastores_panel.rs | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/ui/src/dashboard/pbs_datastores_panel.rs b/ui/src/dashboard/pbs_datastores_panel.rs
> index a06acf7..3e347b9 100644
> --- a/ui/src/dashboard/pbs_datastores_panel.rs
> +++ b/ui/src/dashboard/pbs_datastores_panel.rs
> @@ -102,28 +102,28 @@ fn create_list_tile(
> StatusRow::Online(count) => (
> Fa::from(Status::Success),
> count,
> - "Online",
> + tr!("Online"),
> Some(("online", "status")),
> ),
> StatusRow::HighUsage(count) => (
> Fa::from(Status::Warning),
> count,
> - "High usage",
> + tr!("High usage"),
> Some(("high-usage", "property")),
> ),
> StatusRow::UnderMaintenance(count) => (
> Fa::new("wrench"),
> count,
> - "Under Maintenance",
> + tr!("Under Maintenance"),
> Some(("under-maintenance", "status")),
> ),
> StatusRow::Unknown(count) => (
> Fa::from(Status::Unknown),
> count,
> - "Unknown",
> + tr!("Unknown"),
> Some(("unknown", "property")),
> ),
> - StatusRow::All(count) => (Fa::new("database"), count, "All", None),
> + StatusRow::All(count) => (Fa::new("database"), count, tr!("All"), None),
> };
>
> Some(
Applied, thanks a lot!
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
prev parent reply other threads:[~2025-11-03 13:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-03 13:00 [pdm-devel] " Christian Ebner
2025-11-03 13:16 ` Lukas Wagner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDZ36WM67GLX.1RMTW81Y1JO61@proxmox.com \
--to=l.wagner@proxmox.com \
--cc=c.ebner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox