Re: [pdm-devel] [PATCH yew-comp v2 1/1] notes view: allow hiding the toolbar if editing isn't supported

From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>
Cc: Proxmox Datacenter Manager development discussion
	<pdm-devel@lists.proxmox.com>
Subject: Re: [pdm-devel] [PATCH yew-comp v2 1/1] notes view: allow hiding the toolbar if editing isn't supported
Date: Thu, 23 Oct 2025 13:33:16 +0200	[thread overview]
Message-ID: <DDPO3KZR3ZA3.137XZR2MWSGQ9@proxmox.com> (raw)
In-Reply-To: <cb3c57c4-fbc3-47f2-8a74-1ab1106ac2a5@proxmox.com>

On Thu Oct 23, 2025 at 11:36 AM CEST, Dominik Csapak wrote:
> alternatively we could determine this from the 'on_submit' existence?
> IMHO it does not make much sense if someone
> sets the 'on_submit' call but disables editing, or vice versa
>
> if there is some use case I can't see right now, consider this
> Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>

sure we can do that to, these last two patches were mainly inteded to
show how the context can be used. can adapt this in a v2.

>
> On 10/22/25 3:11 PM, Shannon Sterz wrote:
>> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
>> ---
>> alternatively we could also pass down the path and permissions for the
>> the check and hook this component into the context itself. since we are
>> talking about a single boolean check here, i though this approach
>> provides less overhead and tried to keep it simple.
>>
>>   src/notes_view.rs | 36 +++++++++++++++++++++++-------------
>>   1 file changed, 23 insertions(+), 13 deletions(-)
>>
>> diff --git a/src/notes_view.rs b/src/notes_view.rs
>> index 315163e..9806d63 100644
>> --- a/src/notes_view.rs
>> +++ b/src/notes_view.rs
>> @@ -6,6 +6,7 @@ use anyhow::Error;
>>   use serde::{Deserialize, Serialize};
>>   use serde_json::{json, Value};
>>
>> +use yew::html::IntoPropValue;
>>   use yew::virtual_dom::{VComp, VNode};
>>
>>   use pwt::prelude::*;
>> @@ -64,6 +65,10 @@ pub struct NotesView {
>>       #[builder_cb(IntoSubmitCallback, into_submit_callback, NotesWithDigest)]
>>       #[prop_or_default]
>>       pub on_submit: Option<SubmitCallback<NotesWithDigest>>,
>> +
>> +    #[builder(IntoPropValue, into_prop_value)]
>> +    #[prop_or(true)]
>> +    pub allow_editing: bool,
>>   }
>>
>>   impl NotesView {
>> @@ -163,20 +168,25 @@ impl LoadableComponent for ProxmoxNotesView {
>>       }
>>       fn toolbar(&self, ctx: &LoadableComponentContext<Self>) -> Option<Html> {
>>           let props = ctx.props();
>> -        let toolbar = Toolbar::new()
>> -            .class("pwt-w-100")
>> -            .class("pwt-overflow-hidden")
>> -            .class("pwt-border-bottom")
>> -            .with_child(
>> -                Button::new(tr!("Edit"))
>> -                    .disabled(props.on_submit.is_none())
>> -                    .onclick(
>> -                        ctx.link()
>> -                            .change_view_callback(|_| Some(ViewState::EditNotes)),
>> -                    ),
>> -            );
>>
>> -        Some(toolbar.into())
>> +        if props.allow_editing {
>> +            let toolbar = Toolbar::new()
>> +                .class("pwt-w-100")
>> +                .class("pwt-overflow-hidden")
>> +                .class("pwt-border-bottom")
>> +                .with_child(
>> +                    Button::new(tr!("Edit"))
>> +                        .disabled(props.on_submit.is_none())
>> +                        .onclick(
>> +                            ctx.link()
>> +                                .change_view_callback(|_| Some(ViewState::EditNotes)),
>> +                        ),
>> +                );
>> +
>> +            return Some(toolbar.into());
>> +        }
>> +
>> +        None
>>       }
>>
>>       fn main_view(&self, _ctx: &LoadableComponentContext<Self>) -> Html {
>> --
>> 2.47.3
>>
>>
>>
>> _______________________________________________
>> pdm-devel mailing list
>> pdm-devel@lists.proxmox.com
>> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
>>
>>

_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel