Re: [pdm-devel] [PATCH datacenter-manager v2 00/16] prepare ui for customizable views

["Shannon Sterz" <s.sterz@proxmox.com>]

On Thu Oct 23, 2025 at 10:28 AM CEST, Dominik Csapak wrote:
> This is the first step to have customizable views in the PDM ui.
>
> Patches 1-12 are refactors mostly and should not change behavior.
>
> Patch 13 is an improvement I noticed while doing this series, I can
> send it upfront if wanted.
>
> Patches 14-16 are RFCs because:
> * The `LoadResult` struct should probably live in either pwt or
>   yew-comp, I think Dietmar has already something local so I did not
>   want to interfere there. (We can switch to the one there if it's
>   committed and bumped)
>
> * Not super sure if this kind of structure is the one we desire.
>   The View is (for now) only a single layout (Row) that provides
>   the same behavior as the current layout. The whole logic is in the
>   View and every bit we want to add has to be handled there.
>
> Note that we'll have to move the types for the View/ViewLayout/etc. to
> the pdm-api-types probably, since we'll also want to use them on the
> backend.
>
> changes from v1:
> * rebased on master
> * added new patch to fix dashboard layout after change to views (patch 7)
>
> Dominik Csapak (16):
>   ui: dashboard: refactor guest panel creation to its own module
>   ui: dashboard: refactor creating the node panel into its own module
>   ui: dashboard: refactor remote panel creation into its own module
>   ui: dashboard: remote panel: make wizard menu optional
>   ui: dashboard: refactor sdn panel creation into its own module
>   ui: dashboard: refactor task summary panel creation to its own module
>   ui: dashboard: task summary: disable virtual scrolling
>   ui: dashboard: refactor subscription panel creation to its own module
>   ui: dashboard: refactor top entities panel creation to its own module
>   ui: dashboard: refactor DashboardConfig editing/constants to their
>     module
>   ui: dashboard: factor out task parameter calculation
>   ui: dashboard: remove unused remote list
>   ui: dashboard: status row: make loading less jarring
>   ui: introduce `LoadResult` helper type
>   ui: dashboard: implement 'View'
>   ui: dashboard: use 'View' instead of the Dashboard
>
>  ui/src/dashboard/guest_panel.rs         |  75 ++-
>  ui/src/dashboard/mod.rs                 | 784 +-----------------------
>  ui/src/dashboard/node_panel.rs          | 150 +++++
>  ui/src/dashboard/refresh_config_edit.rs | 107 ++++
>  ui/src/dashboard/remote_panel.rs        |  51 +-
>  ui/src/dashboard/sdn_zone_panel.rs      |  15 +-
>  ui/src/dashboard/status_row.rs          |  11 +-
>  ui/src/dashboard/subscription_info.rs   |  54 +-
>  ui/src/dashboard/tasks.rs               |  41 ++
>  ui/src/dashboard/top_entities.rs        |  45 +-
>  ui/src/dashboard/types.rs               |  78 +++
>  ui/src/dashboard/view.rs                | 515 ++++++++++++++++
>  ui/src/lib.rs                           |   5 +-
>  ui/src/load_result.rs                   |  42 ++
>  ui/src/main_menu.rs                     |   5 +-
>  ui/src/pbs/remote.rs                    |  30 +-
>  ui/src/pve/lxc/overview.rs              |  28 +-
>  ui/src/pve/mod.rs                       |   4 +-
>  ui/src/pve/node/overview.rs             |  29 +-
>  ui/src/pve/qemu/overview.rs             |  28 +-
>  ui/src/pve/storage.rs                   |  29 +-
>  21 files changed, 1202 insertions(+), 924 deletions(-)
>  create mode 100644 ui/src/dashboard/node_panel.rs
>  create mode 100644 ui/src/dashboard/refresh_config_edit.rs
>  create mode 100644 ui/src/dashboard/types.rs
>  create mode 100644 ui/src/dashboard/view.rs
>  create mode 100644 ui/src/load_result.rs

Other than the notes i left, consider this:

Reviewed-by: Shannon Sterz <s.sterz@proxmox.com>
Tested-by: Shannon Sterz <s.sterz@proxmox.com>


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel