Re: [pdm-devel] [PATCH proxmox-datacenter-manager 00/12] add global remote update view

["Shannon Sterz" <s.sterz@proxmox.com>]

On Wed Oct 15, 2025 at 2:46 PM CEST, Lukas Wagner wrote:
> This series adds a new tab under "Remotes" called "Updates". It provides a
> summary regarding the system update availability for all managed remotes.
>
> Potential follow-up work:
>   - The "Refresh all" button, powered by the '/remote-updates/refresh' API
>     only retrieves a fresh list of available updates at the moment, but does not
>     invoke 'apt update' on the remote. The latter could be useful, either
>     always or if explicitly requested, but we probably should 'stream'
>     the node's task log to the PDM task log, so one can see the actual
>     progress and/or any problems.
>
>   - Remote task cache / task tracking needs a bit of work to correctly handle
>     PBS tasks, therefore the 'Update' (which *does* invoke 'apt update' on the
>     remote node) button for a *SINGLE* node does not work yet for PBS.
>
>
> proxmox-datacenter-manager:
>
> Lukas Wagner (12):
>   metric collection task: tests: add missing parameter for
>     cluster_metric_export
>   pdm-api-types: add types for remote upgrade summary
>   remote updates: add cache for remote update availability
>   api: add API for retrieving/refreshing the remote update summary
>   unprivileged api daemon: tasks: add remote update refresh task
>   pdm-client: add API methods for remote update summaries
>   pbs-client: add bindings for APT-related API calls
>   task cache: use separate functions for tracking PVE and PBS tasks
>   remote updates: add support for PBS remotes
>   api: add APT endpoints for PBS remotes
>   ui: add remote update view
>   ui: show new remote update view in the 'Remotes' section
>
>  lib/pdm-api-types/src/lib.rs                  |   2 +
>  lib/pdm-api-types/src/remote_updates.rs       | 126 +++++
>  lib/pdm-client/src/lib.rs                     |  22 +
>  server/src/api/mod.rs                         |   3 +
>  server/src/api/pbs/mod.rs                     |  19 +-
>  server/src/api/pbs/node.rs                    |   9 +
>  server/src/api/pve/apt.rs                     | 119 ----
>  server/src/api/pve/mod.rs                     |   4 +-
>  server/src/api/pve/node.rs                    |   2 +-
>  server/src/api/remote_updates.rs              | 222 ++++++++
>  server/src/bin/proxmox-datacenter-api/main.rs |   1 +
>  .../bin/proxmox-datacenter-api/tasks/mod.rs   |   1 +
>  .../tasks/remote_updates.rs                   |  44 ++
>  .../src/metric_collection/collection_task.rs  |   1 +
>  server/src/pbs_client.rs                      |  51 ++
>  server/src/remote_tasks/mod.rs                |  45 +-
>  server/src/remote_updates.rs                  | 229 +++++++-
>  ui/src/remotes/mod.rs                         |  10 +
>  ui/src/remotes/updates.rs                     | 531 ++++++++++++++++++
>  19 files changed, 1299 insertions(+), 142 deletions(-)
>  create mode 100644 lib/pdm-api-types/src/remote_updates.rs
>  create mode 100644 server/src/api/pbs/node.rs
>  delete mode 100644 server/src/api/pve/apt.rs
>  create mode 100644 server/src/api/remote_updates.rs
>  create mode 100644 server/src/bin/proxmox-datacenter-api/tasks/remote_updates.rs
>  create mode 100644 ui/src/remotes/updates.rs
>
>
> Summary over all repositories:
>   19 files changed, 1299 insertions(+), 142 deletions(-)

had a couple of minor improvements for some patches, but nothing that
blocks this in my opinion (most are simple follow-ups for the ui). since
you already pointed out the usage of UNAUTHORIZED instead of FORBIDDEN
yourself, i didn't send my comments on that here again. so consider
this:

Reviewed-by: Shannon Sterz <s.sterz@proxmox.com>
Tested-by: Shannon Sterz <s.sterz@proxmox.com>



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel