public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>,
	"Proxmox Datacenter Manager development discussion"
	<pdm-devel@lists.proxmox.com>
Subject: Re: [pdm-devel] [PATCH proxmox 1/3] access-control: refactor api module to be more hirachical
Date: Wed, 01 Oct 2025 17:29:54 +0200	[thread overview]
Message-ID: <DD73CS7HMCS3.O0TE71Q1JSRA@proxmox.com> (raw)
In-Reply-To: <1acb29c7-678c-4b6e-bf07-243fc44b7eb2@proxmox.com>

On Fri Sep 26, 2025 at 10:26 AM CEST, Dominik Csapak wrote:
>
>
> On 9/24/25 4:51 PM, Shannon Sterz wrote:
>> this is mainly in preparation of factoring out more api endpoints
>> related to access control. the refactoring is done in a way where
>> users should not need to adapt.
>>
>> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
>> ---
>>   proxmox-access-control/src/{api.rs => api/acl.rs} | 0
>>   proxmox-access-control/src/api/mod.rs             | 8 ++++++++
>>   2 files changed, 8 insertions(+)
>>   rename proxmox-access-control/src/{api.rs => api/acl.rs} (100%)
>>   create mode 100644 proxmox-access-control/src/api/mod.rs
>>
>> diff --git a/proxmox-access-control/src/api.rs b/proxmox-access-control/src/api/acl.rs
>> similarity index 100%
>> rename from proxmox-access-control/src/api.rs
>> rename to proxmox-access-control/src/api/acl.rs
>> diff --git a/proxmox-access-control/src/api/mod.rs b/proxmox-access-control/src/api/mod.rs
>> new file mode 100644
>> index 00000000..59dc32e2
>> --- /dev/null
>> +++ b/proxmox-access-control/src/api/mod.rs
>> @@ -0,0 +1,8 @@
>> +mod tokens;
>> +pub use tokens::{
>> +    API_METHOD_DELETE_TOKEN, API_METHOD_GENERATE_TOKEN, API_METHOD_LIST_TOKENS,
>> +    API_METHOD_READ_TOKEN, API_METHOD_UPDATE_TOKEN,
>> +};
>> +
>> +mod acl;
>> +pub use acl::{ACL_ROUTER, API_METHOD_READ_ACL, API_METHOD_UPDATE_ACL, ROLE_ROUTER};
>
> it seems the hunk here would belong into proxmox 3/3 since there is no
> 'tokens' module yet?

yes, sorry must have messed up in my haste on wednesday, will fix that
in a v2.


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  reply	other threads:[~2025-10-01 15:29 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-24 14:51 [pdm-devel] [RFC datacenter-manager/proxmox/yew-comp 0/8] token support for pdm Shannon Sterz
2025-09-24 14:51 ` [pdm-devel] [PATCH proxmox 1/3] access-control: refactor api module to be more hirachical Shannon Sterz
2025-09-26  8:26   ` Dominik Csapak
2025-10-01 15:29     ` Shannon Sterz [this message]
2025-09-24 14:51 ` [pdm-devel] [PATCH proxmox 2/3] access-control: move `ApiTokenSecret` to types module Shannon Sterz
2025-09-26  9:14   ` Fabian Grünbichler
2025-09-24 14:51 ` [pdm-devel] [PATCH proxmox 3/3] access-control: add api endpoints for handling tokens Shannon Sterz
2025-09-26  9:14   ` Fabian Grünbichler
2025-10-01 15:29     ` Shannon Sterz
2025-09-24 14:51 ` [pdm-devel] [PATCH yew-comp 1/2] utils/user_panel: factor out epoch_to_input_value helper Shannon Sterz
2025-09-27 16:57   ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-24 14:51 ` [pdm-devel] [PATCH yew-comp 2/2] token_panel: implement a token panel Shannon Sterz
2025-09-26  8:50   ` Dominik Csapak
2025-09-27 17:07     ` Thomas Lamprecht
2025-10-02 15:30       ` Shannon Sterz
2025-10-02 15:39         ` Thomas Lamprecht
2025-10-02 15:19     ` Shannon Sterz
2025-09-27 16:57   ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-24 14:51 ` [pdm-devel] [PATCH datacenter-manager 1/3] ui: add a token panel and a token acl edit menu in the permissions panel Shannon Sterz
2025-09-24 14:51 ` [pdm-devel] [PATCH datacenter-manager 2/3] server: access: use token endpoints from proxmox-access-control Shannon Sterz
2025-09-24 14:51 ` [pdm-devel] [PATCH datacenter-manager 3/3] server: clean up acl tree entries and api tokens when deleting users Shannon Sterz
2025-09-26  9:18   ` Fabian Grünbichler
2025-10-01 15:29     ` Shannon Sterz
2025-10-02 10:19       ` Fabian Grünbichler
2025-10-03 14:22 ` [pdm-devel] Superseded: Re: [RFC datacenter-manager/proxmox/yew-comp 0/8] token support for pdm Shannon Sterz
2025-10-03 14:21 [pdm-devel] [PATCH datacenter-manager/proxmox/yew-comp 0/8] add better " Shannon Sterz
2025-10-03 14:21 ` [pdm-devel] [PATCH proxmox 1/3] access-control: refactor api module to be more hirachical Shannon Sterz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DD73CS7HMCS3.O0TE71Q1JSRA@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal