Re: [pdm-devel] [PATCH datacenter-manager/proxmox 0/3] version command and upgrade checks for pdm

["Shannon Sterz" <s.sterz@proxmox.com>]

On Fri Sep 5, 2025 at 5:18 PM CEST, Michael Köppl wrote:
> Tested the upgrade script on a bookworm-based PDM install
>
> - Checked that installed systemd-boot package was detected and warning
>   shown
> - Forced time sync unit checks to warn by installing timesyncd, ntp,
>   uninstalling chrony, etc.
>   scenarios
>   - Having timesyncd installed and active produced the expected warning
>   - Having ntp installed produced the expected info message
> - Checked the various version mismatch cases and if they're reported
>   correctly
>
> Also gave the `versions` command a spin. The only thing I noticed there
> is that the output started with the following line for me:
>     proxmox-datacenter unknown  running kernel: 6.8.12-9-pve
> Is "unknown" expected here?

thanks for the feedback, the output here should depend on the
pre-existing versions endpoint at `GET nodes/{nodename}/apt/versions`
(note that `nodename` is usually just `localhost` as there is no
clustering yet). the unknown stems from proxmox-apt's assumption that
every product has a meta package, which pdm doesn't seems to have yet.

so while this isn't ideal, it is somewhat expected. the output for
`proxmox-datacenter-manager` should be correct, though. the output above
is only shown if you run this command with the `--verbose` flag.

to fix this we could set the meta package name to
`proxmox-datacenter-manager` as well in `server/src/api/nodes/apt.rs @
get_versions()`, but that wil lead to duplicate lines. i'll add a patch
in that regard to v2, it can still be dropped when applying.

> Other than that, I didn't notice anything off. Seems to work as
> advertised. Left 1 comment on the 1/1 patch that adds the
> proxmox-upgrade-checks crate.
>
> Tested-by: Michael Köppl <m.koeppl@proxmox.com>
>
> On Fri Sep 5, 2025 at 11:59 AM CEST, Shannon Sterz wrote:
>> these three patches add an upgrade script to proxmox-datacenter-manager.
>> it also adds a `versions` subcommand to the
>> `proxmox-datacenter-manager-admin` command. they are intended for the
>> bookworm based releases, so that users can check the prerequisites
>> before upgrading to a trixie based release. a similar series for the
>> current trixie-based master branches will follow shortly.
>>
>> the first patch moves the existing checks from pbs to the proxmox
>> repository and make them a little bit more configurable. the second
>> patch then uses these checks in the new `proxmox-upgrade-checks` crate
>> and implements the `pdmAtoB` helper that works the same as other upgrade
>> checking helpers.
>>
>> finally the last commit implements the `versions` subcommand for
>> `proxmox-datacenter-manager-admin` so that it is easier to tell what the
>> currently running version of pdm is.
>>
>> these paches are intended to be applied against the following trees:
>>
>> * in the proxmox repository this should be applied against the
>>   `stable-bookworm` branch.
>> * in the proxmox-datacenter-manager repository the two commits should be
>>   applied against the commit f6ca650d (ui: add woff2 roboto flex variant
>>   to ui packaging)
>>
>> the latter was chosen as it seems to be the last commit in the
>> proxmox-datacenter-manager repo that was intended for bookworm, since
>> that repo is missing a `stable-bookworm` branch so far.
>>
>> proxmox:
>>
>> Shannon Sterz (1):
>>   upgrade-checks: add upgrade checker crate
>>
>>  Cargo.toml                        |   3 +
>>  proxmox-upgrade-checks/Cargo.toml |  21 +
>>  proxmox-upgrade-checks/src/lib.rs | 856 ++++++++++++++++++++++++++++++
>>  3 files changed, 880 insertions(+)
>>  create mode 100644 proxmox-upgrade-checks/Cargo.toml
>>  create mode 100644 proxmox-upgrade-checks/src/lib.rs
>>
>>
>> proxmox-datacenter-manager:
>>
>> Shannon Sterz (2):
>>   server: add pdmAtoB upgrade checker script
>>   cli/admin: add a versions command to show current package versions
>>
>>  Cargo.toml                                |  3 ++
>>  Makefile                                  |  1 +
>>  cli/admin/src/main.rs                     | 53 ++++++++++++++++++++++-
>>  cli/pdmAtoB/Cargo.toml                    | 15 +++++++
>>  cli/pdmAtoB/src/main.rs                   | 19 ++++++++
>>  debian/proxmox-datacenter-manager.install |  3 ++
>>  6 files changed, 92 insertions(+), 2 deletions(-)
>>  create mode 100644 cli/pdmAtoB/Cargo.toml
>>  create mode 100644 cli/pdmAtoB/src/main.rs
>>
>>
>> Summary over all repositories:
>>   9 files changed, 972 insertions(+), 2 deletions(-)
>>
>> --
>> Generated by git-murpp 0.8.1
>>
>>
>> _______________________________________________
>> pdm-devel mailing list
>> pdm-devel@lists.proxmox.com
>> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
>
>
>
> _______________________________________________
> pdm-devel mailing list
> pdm-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel