Re: [pdm-devel] [PATCH datacenter-manager v3 00/23] ] improve remote wizard

From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox Datacenter Manager development discussion"
	<pdm-devel@lists.proxmox.com>,
	"Dominik Csapak" <d.csapak@proxmox.com>,
	"Thomas Lamprecht" <t.lamprecht@proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager v3 00/23] ] improve remote wizard
Date: Thu, 21 Aug 2025 13:45:45 +0200	[thread overview]
Message-ID: <DC82WTUXN9TL.1ZKJOPN2XE9LA@proxmox.com> (raw)
In-Reply-To: <20250821084229.1523597-1-d.csapak@proxmox.com>

On Thu Aug 21, 2025 at 10:39 AM CEST, Dominik Csapak wrote:
> ## Fingerprint confirmation dialogs
>
> Not sure if we want to be able to let the user confirm the fingerprint
> so easily. On one hand it's very convenient, but maybe leads to users
> simply clicking yes without understanding what's happening.
>
> If it's deemed too dangerous, I'd rework the series without this.

As said in v2, I think it's fine to have such a dialog, but I'd like to
hear some other opinions before we apply this.

@Thomas, do you have an opinion on this?

>
> # Future work
>

[snip]

>  ui/src/remotes/wizard_page_connect.rs | 314 +++++++++++++++++---------
>  ui/src/remotes/wizard_page_info.rs    | 121 +++++-----
>  ui/src/remotes/wizard_page_nodes.rs   | 239 +++++++++++++++++++-
>  ui/src/remotes/wizard_page_summary.rs |   5 +-
>  ui/src/widget/mod.rs                  |   3 +
>  ui/src/widget/pve_realm_selector.rs   | 123 ++++++++++
>  15 files changed, 872 insertions(+), 203 deletions(-)
>  create mode 100644 ui/src/widget/pve_realm_selector.rs

Gave this one another go. Code looks good to me, only two minor
complaints about outdated doc comments and one question about the
permissions for the tls-probe endpoint (see individual patches).

Consider this:

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>

Also tested this again, found two small issues:
  - Seems like the realm selector is still not disabled when "Use
    existing token" is selected
  - When you modify something in the "Endpoints" tab (e.g. the IP
    address for some endpoint), go back to "Settings" and then back to
    "Endpoints", the changes are lost - I guess in this case the info is
    fetched again from the API and the changes overwritten.

These could also be fixed in a follow-up, since these do not impeded the
core functionality of the dialog, IMO.

_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel