public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: pdm-devel@lists.proxmox.com
Subject: [pdm-devel] superseded: [PATCH datacenter-manager v4 00/18] enable custom views on the UI
Date: Wed, 26 Nov 2025 16:20:18 +0100	[thread overview]
Message-ID: <942d1390-bafd-42a9-886c-a4fbcec96cb2@proxmox.com> (raw)
In-Reply-To: <20251124120758.2636462-1-d.csapak@proxmox.com>

superseded by v5: 
https://lore.proxmox.com/pdm-devel/20251126151833.3637080-1-d.csapak@proxmox.com/

NOTE: new version depends on lukas changes (see cover-letter)


On 11/24/25 1:08 PM, Dominik Csapak wrote:
> With this series, users are able to add/edit/delete custom views.
> 
> A new 'Views' menu entry is added where the CRUD ui sits, and an entry
> for each view below it.
> 
> The includes/excludes are editable from the CRUD grid, and the layout is
> editable in the view itself.
> 
> For now i opted to make the layout part of the `ViewConfig` struct, but
> as a simple json-string only, because we're not able to use the
> api-macro (for now; the rust enum features i use are currently not
> supported there). To verify it regardless, we try to deserialize
> the layout in the add/update call, so that no wrong layout can enter
> the config (via the api).
> 
> The patch 'ui: dashboard: prepare view for editint custom views'
> is adapted from my last series, but all other changes are new,
> especially the CRUD api.
> 
> There are still a few parts missing/wrong, namely
> * while the api is prepared, clicking on guest status items does not
>    yet populate the search field with a '+view:foo' term
> * subscriptions panels are still added by default when none is in the
>    layout itself (the plan is to move the subscription notice)
> * i'm still working on making the 'resource tree' a full widget that
>    users can add to their views.
> 
> chnages from v3:
> * incorporated most of Shannon's feedback (Thanks!)
>    see the individual patches for changelog
> * rebase on master
> 
> changes from v2:
> * fixed 'verbose' property for subscriptions api call
> * adapted to PveSdnZone -> PveNetwork renaming
> * added validators for filter fields
>    (so that the user sees it's invalid)
> 
> changes from v1:
> * rebase on master, lukas v5 was applied
> 
> Dominik Csapak (18):
>    lib: pdm-config: views: add locking/saving methods
>    lib: api-types: add 'layout' property to ViewConfig
>    server: api: implement CRUD api for views
>    server: api: resources: add 'view' category to search syntax
>    ui: remote selector: allow forcing of value
>    ui: dashboard types: add missing 'default's to de-serialization
>    ui: dashboard: status row: add optional 'editing state'
>    ui: dashboard: prepare view for editing custom views
>    ui: views: implement view loading from api
>    ui: views: make 'view' name property optional
>    ui: views: add 'view' parameter to api calls
>    ui: views: save updated layout to backend
>    ui: add view list context
>    ui: configuration: add view CRUD panels
>    ui: main menu: add optional view_list property
>    ui: load view list on page init
>    lib/ui: move views types to pdm-api-types
>    server: api: views: check layout string for validity
> 
>   lib/pdm-api-types/src/resource.rs     |   7 +
>   lib/pdm-api-types/src/views.rs        |  90 ++++-
>   lib/pdm-config/src/views.rs           |  22 +-
>   server/src/api/config/mod.rs          |   2 +
>   server/src/api/config/views.rs        | 267 +++++++++++++
>   server/src/api/resources.rs           |  19 +-
>   server/src/views/mod.rs               |   2 +-
>   server/src/views/tests.rs             |  15 +
>   ui/Cargo.toml                         |   2 +-
>   ui/css/pdm.scss                       |   4 +
>   ui/src/configuration/mod.rs           |   2 +
>   ui/src/configuration/views.rs         | 335 +++++++++++++++++
>   ui/src/dashboard/mod.rs               |   2 -
>   ui/src/dashboard/status_row.rs        |  60 ++-
>   ui/src/dashboard/top_entities.rs      |   3 +-
>   ui/src/dashboard/types.rs             |  79 ----
>   ui/src/dashboard/view.rs              | 410 ++++++++++++--------
>   ui/src/dashboard/view/row_element.rs  | 130 +++++++
>   ui/src/dashboard/view/row_view.rs     | 520 +++++++++++++++++++++++++-
>   ui/src/lib.rs                         |   3 +
>   ui/src/main.rs                        |  48 ++-
>   ui/src/main_menu.rs                   |  57 ++-
>   ui/src/pve/mod.rs                     |   9 +
>   ui/src/view_list_context.rs           |  31 ++
>   ui/src/widget/mod.rs                  |   6 +
>   ui/src/widget/remote_selector.rs      |   6 +
>   ui/src/widget/view_filter_selector.rs | 393 +++++++++++++++++++
>   ui/src/widget/view_selector.rs        |  55 +++
>   28 files changed, 2315 insertions(+), 264 deletions(-)
>   create mode 100644 server/src/api/config/views.rs
>   create mode 100644 ui/src/configuration/views.rs
>   delete mode 100644 ui/src/dashboard/types.rs
>   create mode 100644 ui/src/dashboard/view/row_element.rs
>   create mode 100644 ui/src/view_list_context.rs
>   create mode 100644 ui/src/widget/view_filter_selector.rs
>   create mode 100644 ui/src/widget/view_selector.rs
> 



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


      parent reply	other threads:[~2025-11-26 15:20 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-11-24 12:07 [pdm-devel] " Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 01/18] lib: pdm-config: views: add locking/saving methods Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 02/18] lib: api-types: add 'layout' property to ViewConfig Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 03/18] server: api: implement CRUD api for views Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 04/18] server: api: resources: add 'view' category to search syntax Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 05/18] ui: remote selector: allow forcing of value Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 06/18] ui: dashboard types: add missing 'default's to de-serialization Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 07/18] ui: dashboard: status row: add optional 'editing state' Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 08/18] ui: dashboard: prepare view for editing custom views Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 09/18] ui: views: implement view loading from api Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 10/18] ui: views: make 'view' name property optional Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 11/18] ui: views: add 'view' parameter to api calls Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 12/18] ui: views: save updated layout to backend Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 13/18] ui: add view list context Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 14/18] ui: configuration: add view CRUD panels Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 15/18] ui: main menu: add optional view_list property Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 16/18] ui: load view list on page init Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 17/18] lib/ui: move views types to pdm-api-types Dominik Csapak
2025-11-24 12:07 ` [pdm-devel] [PATCH datacenter-manager v4 18/18] server: api: views: check layout string for validity Dominik Csapak
2025-11-26 15:20 ` Dominik Csapak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=942d1390-bafd-42a9-886c-a4fbcec96cb2@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal