Re: [pdm-devel] [RFC datacenter-manager 5/8] pdm-api-types: remote upid: add type field to RemoteUpid

From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Datacenter Manager development discussion
	<pdm-devel@lists.proxmox.com>,
	Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pdm-devel] [RFC datacenter-manager 5/8] pdm-api-types: remote upid: add type field to RemoteUpid
Date: Wed, 12 Nov 2025 21:00:27 +0100	[thread overview]
Message-ID: <92fb6cb6-4443-4998-acf4-77b2dac773ac@proxmox.com> (raw)
In-Reply-To: <20251111105059.148997-6-l.wagner@proxmox.com>

Am 11.11.25 um 11:50 schrieb Lukas Wagner:
> diff --git a/lib/pdm-api-types/src/remote_upid.rs b/lib/pdm-api-types/src/remote_upid.rs
> index 454c9b1f..32106e42 100644
> --- a/lib/pdm-api-types/src/remote_upid.rs
> +++ b/lib/pdm-api-types/src/remote_upid.rs
> @@ -5,19 +5,30 @@ use anyhow::{bail, Error};
>  use proxmox_schema::api_types::SAFE_ID_REGEX;
>  use proxmox_schema::{ApiType, Schema, StringSchema};
>  
> +use crate::remotes::RemoteType;
> +
>  pub const REMOTE_UPID_SCHEMA: Schema = StringSchema::new("A remote UPID")
> -    .min_length("C!UPID:N:12345678:12345678:12345678:::".len())
> +    .min_length("abc:C!UPID:N:12345678:12345678:12345678:::".len())

This shouldn't be a problem as all real UPIDs should be quite a bit longer,
but if the string would have been close to the actual realistic minimum
before, increasing the minimum length would be a breaking change, or do I
miss something?

Again, should not matter in practice.

>      .schema();

_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel