Re: [PATCH proxmox-datacenter-manager] pdm-api-types: Add acl feature to access-control

[Thomas Lamprecht <t.lamprecht@proxmox.com>]

Am 02.02.26 um 14:48 schrieb Maximiliano Sandoval:
> To match the changes made in
> https://git.proxmox.com/?p=proxmox.git;a=commitdiff;h=47defa79bd10991d28757a690f7dc283805b2768.
> 
> This fixes the following error while running `cargo build`:
> 
> ```
> $ cargo build
>    Compiling pdm-api-types v1.0.0 (/home/msandoval/Projects/proxmox-datacenter-manager/lib/pdm-api-types)
> error[E0433]: failed to resolve: could not find `init` in `proxmox_access_control`
>    --> lib/pdm-api-types/src/acl.rs:192:30
>     |
> 192 | impl proxmox_access_control::init::AccessControlConfig for AccessControlConfig {
>     |                              ^^^^ could not find `init` in `proxmox_access_control`
>     |
> note: found an item that was configured out
>    --> /usr/share/cargo/registry/proxmox-access-control-1.3.1/src/lib.rs:12:9
>     |
>  11 | #[cfg(feature = "acl")]
>     |       --------------- the item is gated behind the `acl` feature
>  12 | pub mod init;
>     |         ^^^^
> 
> error[E0433]: failed to resolve: could not find `acl` in `proxmox_access_control`
>    --> lib/pdm-api-types/src/acl.rs:257:50
>     |
> 257 |         let components = proxmox_access_control::acl::split_acl_path(path);
>     |                                                  ^^^ could not find `acl` in `proxmox_access_control`
>     |
> note: found an item that was configured out
>    --> /usr/share/cargo/registry/proxmox-access-control-1.3.1/src/lib.rs:6:9
>     |
>   5 | #[cfg(feature = "acl")]
>     |       --------------- the item is gated behind the `acl` feature
>   6 | pub mod acl;
>     |         ^^^
> 
> For more information about this error, try `rustc --explain E0433`.
> error: could not compile `pdm-api-types` (lib) due to 2 previous errors
> ```

This is just not a good commit message, how is having the whole compiler output
helpful as rationale?
One either has to follow the link or interpret a whole lot of verbose info, as
the compiler cannot be sure about what the actual fix is, that could have
been rather stated explicitly:

proxmox-access-control gained an `acl` feature [0] to provide more granular
access to the ACLTree and related types, which we now need to opt-into here"

[0]: https://git.proxmox.com/?p=proxmox.git;a=commitdiff;h=47defa79bd10991d28757a690f7dc283805b2768.

@Lukas: please keep commit hygiene in mind, such things can also be fixed
up on applying, depending on the changes needed.

> 
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  lib/pdm-api-types/Cargo.toml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/lib/pdm-api-types/Cargo.toml b/lib/pdm-api-types/Cargo.toml
> index d6429e6a..7aa7b64e 100644
> --- a/lib/pdm-api-types/Cargo.toml
> +++ b/lib/pdm-api-types/Cargo.toml
> @@ -14,7 +14,7 @@ serde.workspace = true
>  serde_plain.workspace = true
>  
>  proxmox-acme-api.workspace = true
> -proxmox-access-control.workspace = true
> +proxmox-access-control = { workspace = true, features = ["acl"] }
>  proxmox-auth-api = { workspace = true, features = ["api-types"] }
>  proxmox-apt-api-types.workspace = true
>  proxmox-lang.workspace = true