From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>, pdm-devel@lists.proxmox.com
Subject: Re: [PATCH datacenter-manager 4/5] parallel fetcher: improve result type ergonomics
Date: Thu, 5 Feb 2026 19:17:44 +0100 [thread overview]
Message-ID: <894ed689-9f65-4ff2-8a4d-6419bdc566c9@proxmox.com> (raw)
In-Reply-To: <20260204152723.482258-5-l.wagner@proxmox.com>
Am 04.02.26 um 16:27 schrieb Lukas Wagner:
> Completely overhaul the *Result types:
> - use the term 'Outcome' instead of result, to avoid confusion with
> Rust's Result type
I do not want to bikeshed this to much, but if we touch it then a bit
might be ok, with that in mind: why not Response? Outcome just has a bit
to abstract ring to me.
Rest seems OK to me, albeit I only skimmed the changes. The module level
docs are highly appreciated, but won't apply them until above is cleared
up.
> - use generics to avoid the awkwardness of accessing the node outcome
> of a single node when using do_for_all_remotes (we only call out to
> a single node anyways)
> - implement .iter()/.into_iter() where it makes sense for conveniently
> iterating over remote outcomes and node outcomes
> - make all members private and offer getters to access fields
> - use a sorted vec as an internal data structure for storing
> remote outcomes instead a hash map. This avoids the awkwardness of
> having the remote name as key *and* in the struct that is used as a
> value. Since the vec is sorted by the remote name, we still can
> access specific remotes quite effectively via binary search.
next prev parent reply other threads:[~2026-02-05 18:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-04 15:27 [PATCH datacenter-manager 0/5] improvements for ParallelFetcher Lukas Wagner
2026-02-04 15:27 ` [PATCH datacenter-manager 1/5] parallel fetcher: clean up imports Lukas Wagner
2026-02-05 18:08 ` applied: " Thomas Lamprecht
2026-02-04 15:27 ` [PATCH datacenter-manager 2/5] parallel fetcher: make sure to inherit log context Lukas Wagner
2026-02-05 18:08 ` applied: " Thomas Lamprecht
2026-02-04 15:27 ` [PATCH datacenter-manager 3/5] parallel fetcher: add builder and make struct members private Lukas Wagner
2026-02-05 18:08 ` applied: " Thomas Lamprecht
2026-02-04 15:27 ` [PATCH datacenter-manager 4/5] parallel fetcher: improve result type ergonomics Lukas Wagner
2026-02-05 18:17 ` Thomas Lamprecht [this message]
2026-02-04 15:27 ` [PATCH datacenter-manager 5/5] parallel fetcher: add module documentation Lukas Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=894ed689-9f65-4ff2-8a4d-6419bdc566c9@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox