public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Proxmox Datacenter Manager development discussion
	<pdm-devel@lists.proxmox.com>,
	Stefan Hanreich <s.hanreich@proxmox.com>
Subject: Re: [pdm-devel] [PATCH proxmox-datacenter-manager 0/3] fix pdm build for trixie
Date: Tue, 12 Aug 2025 09:08:36 +0200	[thread overview]
Message-ID: <85e02f3e-f842-44ce-b952-9d7ef6357d71@proxmox.com> (raw)
In-Reply-To: <20250811141847.271476-1-s.hanreich@proxmox.com>

all 3 patches look good to me (and I would have arrived pretty much at 
the same changes)

so consider this

Tested-by: Dominik Csapak <d.csapak@proxmox.com>
Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>

(can also apply them myself if someone else gives their r-b/t-b)

On 8/11/25 16:18, Stefan Hanreich wrote:
> Some additional properties got introduced for existing structs, which prevented
> PDM from building on Trixie. Also, on startup the privileged API would
> immediately fail setting the owner of the priv socket, so fix that as well.
> 
> proxmox-datacenter-manager:
> 
> Stefan Hanreich (3):
>    qemu: set with_conntrack_state when remote migrating
>    api: privileged: fix fchownat call
>    lxc: qemu: set new status properties
> 
>   server/src/api/pve/qemu.rs                          |  1 +
>   server/src/bin/proxmox-datacenter-privileged-api.rs | 13 +++----------
>   ui/src/pve/lxc.rs                                   |  5 +++++
>   ui/src/pve/qemu.rs                                  |  7 +++++++
>   4 files changed, 16 insertions(+), 10 deletions(-)
> 
> 
> Summary over all repositories:
>    4 files changed, 16 insertions(+), 10 deletions(-)
> 



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  parent reply	other threads:[~2025-08-12  7:07 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-11 14:18 Stefan Hanreich
2025-08-11 14:18 ` [pdm-devel] [PATCH proxmox-datacenter-manager 1/3] qemu: set with_conntrack_state when remote migrating Stefan Hanreich
2025-08-12  8:02   ` [pdm-devel] applied: " Dominik Csapak
2025-08-11 14:18 ` [pdm-devel] [PATCH proxmox-datacenter-manager 2/3] api: privileged: fix fchownat call Stefan Hanreich
2025-08-12  7:31   ` Lukas Wagner
2025-08-12  8:03     ` Dominik Csapak
2025-08-11 14:18 ` [pdm-devel] [PATCH proxmox-datacenter-manager 3/3] lxc: qemu: set new status properties Stefan Hanreich
2025-08-12  8:02   ` [pdm-devel] applied: " Dominik Csapak
2025-08-12  7:08 ` Dominik Csapak [this message]
2025-08-12  7:32   ` [pdm-devel] [PATCH proxmox-datacenter-manager 0/3] fix pdm build for trixie Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=85e02f3e-f842-44ce-b952-9d7ef6357d71@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    --cc=s.hanreich@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal