public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pdm-devel] [PATCH datacenter-manager v2] server: api: resources: handle template in status count
@ 2025-04-18  6:15 Dominik Csapak
  2025-04-18  6:43 ` Dominik Csapak
  0 siblings, 1 reply; 2+ messages in thread
From: Dominik Csapak @ 2025-04-18  6:15 UTC (permalink / raw)
  To: pdm-devel

Originally, the PVE API schema description did not include the template
flag (so the information was not present in the rust types), and after
adding it, we forgot to update this part of the code to count the
templates correctly.

Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
changes from v1:
* add commit message to explain why we do this now

 server/src/api/resources.rs | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/server/src/api/resources.rs b/server/src/api/resources.rs
index 453d9e8..ddcee7e 100644
--- a/server/src/api/resources.rs
+++ b/server/src/api/resources.rs
@@ -191,14 +191,14 @@ pub async fn get_status(
                     _ => counts.storages.unknown += 1,
                 },
                 Resource::PveQemu(r) => match r.status.as_str() {
+                    _ if r.template => counts.qemu.template += 1,
                     "running" => counts.qemu.running += 1,
-                    // FIXME: handle templates
                     "stopped" => counts.qemu.stopped += 1,
                     _ => counts.qemu.unknown += 1,
                 },
                 Resource::PveLxc(r) => match r.status.as_str() {
+                    _ if r.template => counts.lxc.template += 1,
                     "running" => counts.lxc.running += 1,
-                    // FIXME: handle templates
                     "stopped" => counts.lxc.stopped += 1,
                     _ => counts.lxc.unknown += 1,
                 },
-- 
2.39.5



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [pdm-devel] [PATCH datacenter-manager v2] server: api: resources: handle template in status count
  2025-04-18  6:15 [pdm-devel] [PATCH datacenter-manager v2] server: api: resources: handle template in status count Dominik Csapak
@ 2025-04-18  6:43 ` Dominik Csapak
  0 siblings, 0 replies; 2+ messages in thread
From: Dominik Csapak @ 2025-04-18  6:43 UTC (permalink / raw)
  To: pdm-devel

superseded by a v3:
https://lore.proxmox.com/pdm-devel/20250418064250.622118-1-d.csapak@proxmox.com/


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-04-18  6:44 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-04-18  6:15 [pdm-devel] [PATCH datacenter-manager v2] server: api: resources: handle template in status count Dominik Csapak
2025-04-18  6:43 ` Dominik Csapak

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal