Re: [pdm-devel] [PATCH datacenter-manager v2 11/12] pdm-client: resource list: add view-filter parameter

[Dominik Csapak <d.csapak@proxmox.com>]

Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>

On 11/3/25 1:36 PM, Lukas Wagner wrote:
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>   cli/client/src/resources.rs | 2 +-
>   lib/pdm-client/src/lib.rs   | 9 ++++++++-
>   ui/src/sdn/zone_tree.rs     | 2 +-
>   3 files changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/cli/client/src/resources.rs b/cli/client/src/resources.rs
> index dbf9f265..bc3a98ba 100644
> --- a/cli/client/src/resources.rs
> +++ b/cli/client/src/resources.rs
> @@ -31,7 +31,7 @@ pub fn cli() -> CommandLineInterface {
>   )]
>   /// List all the remotes this instance is managing.
>   async fn get_resources(max_age: Option<u64>) -> Result<(), Error> {
> -    let mut resources = client()?.resources(max_age).await?;
> +    let mut resources = client()?.resources(max_age, None).await?;
>       let output_format = env().format_args.output_format;
>       if output_format == OutputFormat::Text {
>           if resources.is_empty() {
> diff --git a/lib/pdm-client/src/lib.rs b/lib/pdm-client/src/lib.rs
> index 0cab7691..7102ee05 100644
> --- a/lib/pdm-client/src/lib.rs
> +++ b/lib/pdm-client/src/lib.rs
> @@ -863,9 +863,14 @@ impl<T: HttpApiClient> PdmClient<T> {
>           Ok(self.0.get(&path).await?.expect_json()?.data)
>       }
>   
> -    pub async fn resources(&self, max_age: Option<u64>) -> Result<Vec<RemoteResources>, Error> {
> +    pub async fn resources(
> +        &self,
> +        max_age: Option<u64>,
> +        view_filter: Option<&str>,
> +    ) -> Result<Vec<RemoteResources>, Error> {
>           let path = ApiPathBuilder::new("/api2/extjs/resources/list")
>               .maybe_arg("max-age", &max_age)
> +            .maybe_arg("view-filter", &view_filter)
>               .build();
>           Ok(self.0.get(&path).await?.expect_json()?.data)
>       }
> @@ -874,10 +879,12 @@ impl<T: HttpApiClient> PdmClient<T> {
>           &self,
>           max_age: Option<u64>,
>           resource_type: ResourceType,
> +        view_filter: Option<&str>,
>       ) -> Result<Vec<RemoteResources>, Error> {
>           let path = ApiPathBuilder::new("/api2/extjs/resources/list")
>               .maybe_arg("max-age", &max_age)
>               .arg("resource-type", resource_type)
> +            .maybe_arg("view-filter", &view_filter)
>               .build();
>   
>           Ok(self.0.get(&path).await?.expect_json()?.data)
> diff --git a/ui/src/sdn/zone_tree.rs b/ui/src/sdn/zone_tree.rs
> index 1f534388..7475483d 100644
> --- a/ui/src/sdn/zone_tree.rs
> +++ b/ui/src/sdn/zone_tree.rs
> @@ -281,7 +281,7 @@ impl LoadableComponent for ZoneTreeComponent {
>           Box::pin(async move {
>               let client = pdm_client();
>               let remote_resources = client
> -                .resources_by_type(None, ResourceType::PveSdnZone)
> +                .resources_by_type(None, ResourceType::PveSdnZone, None)
>                   .await?;
>               link.send_message(Self::Message::LoadFinished(remote_resources));
>   



_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel