From: Dominik Csapak <d.csapak@proxmox.com>
To: Stefan Hanreich <s.hanreich@proxmox.com>,
Proxmox Datacenter Manager development discussion
<pdm-devel@lists.proxmox.com>
Subject: Re: [pdm-devel] [PATCH network/proxmox{, -backup, -api-types, -datacenter-manager} v2 00/30] Add initial SDN / EVPN integration
Date: Tue, 2 Sep 2025 14:29:26 +0200 [thread overview]
Message-ID: <6d2b2219-7cd8-4e35-8000-3eebaa16ac12@proxmox.com> (raw)
In-Reply-To: <0f2df6d7-0e68-4168-bb60-99ca6e4d34df@proxmox.com>
On 9/2/25 2:03 PM, Stefan Hanreich wrote:
> On 9/2/25 1:10 PM, Dominik Csapak wrote:
>> setup a few remotes created a few zones/vnets, series tested mostly fine
>> (did not do too extensive testing though)
>>
>> noticed one thing that can probably be improved (i think on the pve
>> side?): when i try to create e.g. a vnet with an id that already exists
>>
>> i get
>> ---8<---
>> 2025-09-02T13:04:14+02:00: failed to execute transaction on remote pve-
>> ceph-cluster: api error (status = 500: create sdn vnet object failed:
>> sdn vnet object ID 'foo' already defined
>> )
>> 2025-09-02T13:04:14+02:00: could not rollback and unlock configuration
>> for remote pve-ceph-cluster - configuration needs to be manually
>> unlocked via 'pvesh delete /cluster/sdn/lock --force 1'
>> --->8---
>>
>> two things here:
>> * there is a stray newline in the error message
>> * detecting duplicates should already be detected before applying
>> and we should be able to roll them back?
>
> is it possible that this remote doesn't have the pve-network patches
> that add the return statement? Without them the issue is that the
> rollback on PVE side happens, but the response from the PVE side cannot
> be parsed (since it doesnt fit the JSONSchema defined there) and
> therefore leads to this error. We might be able to work around by this
> overriding the auto-generated Rust types in generate.pl as well, but
> that seemed suboptimal as well.
ah yes you're right, with new pve-network on that remote it works
the question remains if we want to gracefully handle
older versions too... but for now it's fine i think
_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
next prev parent reply other threads:[~2025-09-02 12:29 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 14:52 Stefan Hanreich
2025-08-29 14:52 ` [pdm-devel] [PATCH proxmox v2 1/2] schema: use i64 for minimum / maximum / default integer values Stefan Hanreich
2025-08-29 14:52 ` [pdm-devel] [PATCH proxmox v2 2/2] pbs-api-types: fix values for integer schemas Stefan Hanreich
2025-08-29 14:52 ` [pdm-devel] [PATCH proxmox-backup v2 1/1] api: change integer schema parameters to i64 Stefan Hanreich
2025-08-29 14:52 ` [pdm-devel] [PATCH pve-network v2 1/6] sdn: api: return null for rollback / lock endpoints Stefan Hanreich
2025-08-29 14:52 ` [pdm-devel] [PATCH pve-network v2 2/6] controllers: fix maximum value for ASN Stefan Hanreich
2025-08-29 14:52 ` [pdm-devel] [PATCH pve-network v2 3/6] api: add state standard option Stefan Hanreich
2025-08-29 14:52 ` [pdm-devel] [PATCH pve-network v2 4/6] api: controllers: update schema of endpoints Stefan Hanreich
2025-08-29 14:52 ` [pdm-devel] [PATCH pve-network v2 5/6] api: vnets: " Stefan Hanreich
2025-08-29 14:52 ` [pdm-devel] [PATCH pve-network v2 6/6] api: zones: " Stefan Hanreich
2025-08-29 14:52 ` [pdm-devel] [PATCH proxmox-api-types v2 1/6] sdn: add list/create zone endpoints Stefan Hanreich
2025-08-29 14:52 ` [pdm-devel] [PATCH proxmox-api-types v2 2/6] sdn: add list/create vnet endpoints Stefan Hanreich
2025-08-29 14:52 ` [pdm-devel] [PATCH proxmox-api-types v2 3/6] sdn: add list/create controller endpoints Stefan Hanreich
2025-08-29 14:52 ` [pdm-devel] [PATCH proxmox-api-types v2 4/6] sdn: add sdn configuration locking endpoints Stefan Hanreich
2025-08-29 14:52 ` [pdm-devel] [PATCH proxmox-api-types v2 5/6] tasks: add helper for querying successfully finished tasks Stefan Hanreich
2025-08-29 14:52 ` [pdm-devel] [PATCH proxmox-api-types v2 6/6] sdn: add helpers for pending values Stefan Hanreich
2025-08-29 14:52 ` [pdm-devel] [PATCH proxmox-datacenter-manager v2 01/15] server: add locked sdn client helpers Stefan Hanreich
2025-08-29 14:52 ` [pdm-devel] [PATCH proxmox-datacenter-manager v2 02/15] ui: pve: sdn: add descriptions for sdn tasks Stefan Hanreich
2025-08-29 14:52 ` [pdm-devel] [PATCH proxmox-datacenter-manager v2 03/15] api: sdn: add list_zones endpoint Stefan Hanreich
2025-09-01 13:36 ` Dominik Csapak
2025-08-29 14:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v2 04/15] api: sdn: add create_zone endpoint Stefan Hanreich
2025-08-29 14:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v2 05/15] api: sdn: add list_vnets endpoint Stefan Hanreich
2025-08-29 14:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v2 06/15] api: sdn: add create_vnet endpoint Stefan Hanreich
2025-08-29 14:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v2 07/15] api: sdn: add list_controllers endpoint Stefan Hanreich
2025-08-29 14:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v2 08/15] ui: sdn: add EvpnRouteTarget type Stefan Hanreich
2025-08-29 14:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v2 09/15] ui: sdn: add vnet icon Stefan Hanreich
2025-08-29 14:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v2 10/15] ui: sdn: add view for showing evpn zones Stefan Hanreich
2025-08-29 14:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v2 11/15] ui: sdn: add view for showing ip vrfs Stefan Hanreich
2025-08-29 14:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v2 12/15] ui: sdn: add component for creating evpn vnets Stefan Hanreich
2025-08-29 14:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v2 13/15] ui: sdn: add component for creatin evpn zones Stefan Hanreich
2025-08-29 14:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v2 14/15] ui: sdn: add evpn overview panel Stefan Hanreich
2025-09-01 13:44 ` Dominik Csapak
2025-09-01 15:02 ` Stefan Hanreich
2025-09-02 6:34 ` Dominik Csapak
2025-09-02 9:30 ` Dominik Csapak
2025-09-02 12:22 ` Stefan Hanreich
2025-08-29 14:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v2 15/15] ui: sdn: add evpn panel to main menu Stefan Hanreich
2025-09-02 11:10 ` [pdm-devel] [PATCH network/proxmox{, -backup, -api-types, -datacenter-manager} v2 00/30] Add initial SDN / EVPN integration Dominik Csapak
2025-09-02 12:03 ` Stefan Hanreich
2025-09-02 12:29 ` Dominik Csapak [this message]
2025-09-02 12:54 ` Stefan Hanreich
2025-09-02 14:10 ` [pdm-devel] superseded: " Stefan Hanreich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d2b2219-7cd8-4e35-8000-3eebaa16ac12@proxmox.com \
--to=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
--cc=s.hanreich@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox