Re: [pdm-devel] [PATCH proxmox-datacenter-manager v2 03/28] pdm-api-types: add CollectionSettings type

From: Lukas Wagner <l.wagner@proxmox.com>
To: Wolfgang Bumiller <w.bumiller@proxmox.com>
Cc: pdm-devel@lists.proxmox.com
Subject: Re: [pdm-devel] [PATCH proxmox-datacenter-manager v2 03/28] pdm-api-types: add CollectionSettings type
Date: Fri, 21 Feb 2025 09:27:47 +0100	[thread overview]
Message-ID: <6a3f43fe-0bf7-4895-8743-efc4044e5e1d@proxmox.com> (raw)
In-Reply-To: <aguxeubkyqnqrfsrmmo4suxmap34ep34bhs5l3rhhqrjr33hlo@vw7u7jhojkka>

On  2025-02-18 16:26, Wolfgang Bumiller wrote:
>> +
>> +#[api(
>> +    properties: {
>> +        "collection-interval" : {
>> +            optional: true,
>> +            default: DEFAULT_COLLECTION_INTERVAL as isize,
>> +            minimum: MIN_COLLECTION_INTERVAL as isize,
>> +            maximum: MAX_COLLECTION_INTERVAL as isize,
> 
> I thought about this the first time around but then forgot again:
> 
> Given that it is possible we might change these types (see Stefan's
> patch for proxmox-schema) and because it is much more convenient
> anyway you could use `as _` for these casts.
> 
> While I'm usually not a fan of `_` casts - I think this might be okay
> for schema declarations.
> 
> (No need for a v3 if there's nothing else...)
> 

Ack, I'll send a follow up if nothing else comes up, else I'll fix it in v3.

-- 
- Lukas

_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel