* [PATCH datacenter-manager] api: network: drop superfluous clippy attribute
@ 2026-09-25 9:34 Christoph Heiss
2026-09-28 9:10 ` Robert Obkircher
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Heiss @ 2026-09-25 9:34 UTC (permalink / raw)
To: pdm-devel
Probably a leftover from copy-paste. Does nothing here, as the function
only has two parameters anyway.
Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
---
server/src/api/nodes/network.rs | 1 -
1 file changed, 1 deletion(-)
diff --git a/server/src/api/nodes/network.rs b/server/src/api/nodes/network.rs
index 3b97f970..67720424 100644
--- a/server/src/api/nodes/network.rs
+++ b/server/src/api/nodes/network.rs
@@ -110,7 +110,6 @@ pub fn read_interface(iface: String, rpcenv: &mut dyn RpcEnvironment) -> Result<
},
)]
/// Create network interface configuration.
-#[allow(clippy::too_many_arguments)]
pub fn create_interface(iface: String, config: InterfaceUpdater) -> Result<(), Error> {
proxmox_network_api::create_interface(iface, config)
}
--
2.55.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH datacenter-manager] api: network: drop superfluous clippy attribute
2026-09-25 9:34 [PATCH datacenter-manager] api: network: drop superfluous clippy attribute Christoph Heiss
@ 2026-09-28 9:10 ` Robert Obkircher
0 siblings, 0 replies; 2+ messages in thread
From: Robert Obkircher @ 2026-09-28 9:10 UTC (permalink / raw)
To: pdm-devel
On 25.09.26 11:40, Christoph Heiss wrote:
> Probably a leftover from copy-paste. Does nothing here, as the function
> only has two parameters anyway.
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> server/src/api/nodes/network.rs | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/server/src/api/nodes/network.rs b/server/src/api/nodes/network.rs
> index 3b97f970..67720424 100644
> --- a/server/src/api/nodes/network.rs
> +++ b/server/src/api/nodes/network.rs
> @@ -110,7 +110,6 @@ pub fn read_interface(iface: String, rpcenv: &mut dyn RpcEnvironment) -> Result<
> },
> )]
> /// Create network interface configuration.
> -#[allow(clippy::too_many_arguments)]
> pub fn create_interface(iface: String, config: InterfaceUpdater) -> Result<(), Error> {
> proxmox_network_api::create_interface(iface, config)
> }
(We should start using the #[expect(..)] attribute to prevent similar
issues in the future)
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-28 9:10 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-25 9:34 [PATCH datacenter-manager] api: network: drop superfluous clippy attribute Christoph Heiss
2026-09-28 9:10 ` Robert Obkircher
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox