public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Dominik Csapak <d.csapak@proxmox.com>
To: Lukas Wagner <l.wagner@proxmox.com>, pdm-devel@lists.proxmox.com
Subject: Re: [PATCH datacenter-manager] ui: pbs: add tasks to node tab panel
Date: Thu, 2 Apr 2026 13:09:02 +0200	[thread overview]
Message-ID: <60f1a75d-7e19-4aa6-9940-16c7729f1efd@proxmox.com> (raw)
In-Reply-To: <DHIM48VGB76J.2RTV4TFFCSPRQ@proxmox.com>



On 4/2/26 12:54 PM, Lukas Wagner wrote:
> On Mon Mar 9, 2026 at 3:37 PM CET, Dominik Csapak wrote:
>> Similar to PVE, but since we don't have a 'Datacenter' tab panel, simply
>> use the 'node' one, since there can only be one for PBS anyway.
>>
>> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
>> ---
>>   ui/src/pbs/node/mod.rs | 12 +++++++++++-
>>   1 file changed, 11 insertions(+), 1 deletion(-)
>>
>> diff --git a/ui/src/pbs/node/mod.rs b/ui/src/pbs/node/mod.rs
>> index abb1f6a6..6d2f46b8 100644
>> --- a/ui/src/pbs/node/mod.rs
>> +++ b/ui/src/pbs/node/mod.rs
>> @@ -17,7 +17,7 @@ pub(crate) mod overview;
>>   
>>   use overview::PbsNodeOverviewPanel;
>>   
>> -use crate::get_deep_url_low_level;
>> +use crate::{get_deep_url_low_level, remotes::RemoteTaskList};
>>   
>>   #[derive(Clone, Debug, Eq, PartialEq, Properties)]
>>   pub struct PbsNodePanel {
>> @@ -78,6 +78,16 @@ impl yew::Component for PbsNodePanelComp {
>>                       move |_| PbsNodeOverviewPanel::new(remote.clone()).into()
>>                   },
>>               )
>> +            .with_item_builder(
>> +                TabBarItem::new()
>> +                    .key("tasks_view")
>> +                    .label(tr!("Tasks"))
>> +                    .icon_class("fa fa-list"),
>> +                {
>> +                    let remote = props.remote.clone();
>> +                    move |_| RemoteTaskList::new().remote(remote.clone()).into()
>> +                },
>> +            )
>>               .with_item_builder(
>>                   TabBarItem::new()
>>                       .key("update_view")
> 
> I wonder, should we also add a 'per-node' Tasks tab for PVE remotes?
> What do you think?
> 

mhmm can make sense, but maybe a better option would be to add a node
selector to the tasks on datacenter level? (maybe both?)

I just fear that we might overload the interface with too many options
if we do this for everything (but that fear might be unfounded :P )




      reply	other threads:[~2026-04-02 11:08 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-09 14:37 Dominik Csapak
2026-04-02 10:55 ` Lukas Wagner
2026-04-02 11:09   ` Dominik Csapak [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=60f1a75d-7e19-4aa6-9940-16c7729f1efd@proxmox.com \
    --to=d.csapak@proxmox.com \
    --cc=l.wagner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal