Re: [pdm-devel] [RFC datacenter-manager 4/5] ui: dashboard: show datastores with upwards trend in stats panel

[Christian Ebner <c.ebner@proxmox.com>]

On 10/29/25 11:20 AM, Shannon Sterz wrote:
> On Mon Oct 27, 2025 at 3:25 PM CET, Christian Ebner wrote:
>> Shows and allow to filter for datastores which have an upwards trend
>> which would lead to the datastore being full shortly.
>>
>> Signed-off-by: Christian Ebner <c.ebner@proxmox.com>
>> ---
>>   ui/src/dashboard/pbs_datastores_panel.rs | 10 +++++++++-
>>   1 file changed, 9 insertions(+), 1 deletion(-)
>>
>> diff --git a/ui/src/dashboard/pbs_datastores_panel.rs b/ui/src/dashboard/pbs_datastores_panel.rs
>> index 4cfc0c8..ece918d 100644
>> --- a/ui/src/dashboard/pbs_datastores_panel.rs
>> +++ b/ui/src/dashboard/pbs_datastores_panel.rs
>> @@ -4,7 +4,7 @@ use pdm_api_types::resource::{PbsDatastoreStatusCount, ResourceType};
>>   use pdm_search::{Search, SearchTerm};
>>   use proxmox_yew_comp::Status;
>>   use pwt::{
>> -    css::{self, TextAlign},
>> +    css::{self, FontColor, TextAlign},
>>       prelude::*,
>>       widget::{Container, Fa, List, ListTile},
>>   };
>> @@ -43,6 +43,7 @@ pub enum StatusRow {
>>       Removable(u64),
>>       S3Backend(u64),
>>       CriticalUsage(u64),
>> +    UptrendingUsage(u64),
>>       Unknown(u64),
>>       All(u64),
>>   }
>> @@ -78,6 +79,7 @@ impl yew::Component for PbsDatastoresPanelComponent {
>>               StatusRow::Removable(status.removable.unwrap_or_default()),
>>               StatusRow::S3Backend(status.s3_backend.unwrap_or_default()),
>>               StatusRow::CriticalUsage(status.critical_usage.unwrap_or_default()),
>> +            StatusRow::UptrendingUsage(status.uptrending_usage.unwrap_or_default()),
>>               StatusRow::Unknown(status.unknown.unwrap_or_default()),
>>               StatusRow::All(status.online + status.in_maintenance.unwrap_or_default()),
>>           ];
>> @@ -115,6 +117,12 @@ fn create_list_tile(
>>               "Critical Usage",
>>               Some(("critical-usage", "property")),
>>           ),
>> +        StatusRow::UptrendingUsage(count) => (
>> +            Fa::new("arrow-up").class(FontColor::Warning),
>> +            count,
>> +            "Uptrendig Usage",
> 
> i know this is pre-existing here, but this would benefit from being
> translate-able imo. so would quite a few others here in this list (e.g.
> "Critical Usage", "In Maintenance" etc). so consider making this
> 
> tr!("Uptrendig Usage")

Right, thanks for noticing!

Will send that as independent patch though, best on top of 
https://lore.proxmox.com/pdm-devel/20251029100958.309086-1-c.ebner@proxmox.com/T/


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel