public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Datacenter Manager development discussion
	<pdm-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>
Subject: Re: [pdm-devel] [PATCH datacenter-manager 1/2] server: api: subscription: improve cache and update behavior
Date: Wed, 3 Dec 2025 21:47:25 +0100	[thread overview]
Message-ID: <5d53eb03-4e75-4a2b-8d08-bbd200db018e@proxmox.com> (raw)
In-Reply-To: <20251203143439.3595966-1-d.csapak@proxmox.com>

Am 03.12.25 um 15:34 schrieb Dominik Csapak:
> To avoid long load times in the ui, use only cached entries for
> subscription info in the GET subscription api call by default, but add a
> 'force-load' parameter to restore the previous behavior.
> 
> The check_subscription api call now always load from all remotes to get
> the most up-to-date information from them.

hmm, this gets a bit confusing to me. Renaming the param to "cache-only"
would make that a bit better, as your name suggests that we always load
now, but with that param passed we still use the cache as long as the
age there is below max-age.

That said, I'm not sure this is the route I'd like to go at all, so just
lets not rush it and revisit this in a few days/weeks again.


What I'd probably would prefer is caching the unknown result and early
returning when that is recent enough.
Actually, it might be nice to have a global unknown (or offline) remote
(+ nodes?) cache, where we save when a remote was unknown and if it was
often in a certain time period we skip it from querying at all and short
circuit that to unknown in all places. This naturally needs to be fleshed
out and needs a bit of care, e.g., users should be able to see (and
manually clear) this state.


_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


      parent reply	other threads:[~2025-12-03 20:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-03 14:34 Dominik Csapak
2025-12-03 14:34 ` [pdm-devel] [PATCH datacenter-manager 2/2] ui: subscription: use 'force-load' parameter Dominik Csapak
2025-12-03 20:47 ` Thomas Lamprecht [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5d53eb03-4e75-4a2b-8d08-bbd200db018e@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal