public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Proxmox Datacenter Manager development discussion
	<pdm-devel@lists.proxmox.com>,
	Dominik Csapak <d.csapak@proxmox.com>,
	Lukas Wagner <l.wagner@proxmox.com>
Subject: Re: [pdm-devel] [PATCH proxmox-datacenter-manager v6 00/23] metric collection improvements (concurrency, API, CLI)
Date: Wed, 27 Aug 2025 09:19:59 +0200	[thread overview]
Message-ID: <5b4de73b-2be5-463a-9b03-167df8354a65@proxmox.com> (raw)
In-Reply-To: <3584b07f-92b7-4cf6-a0f4-6adf7f5752d6@proxmox.com>

On 21/08/2025 14:54, Dominik Csapak wrote:
> just a first high level question while i'm testing/reviewing this:
> 
> when using this patch, it seems the collection interval is much reduced?
> 
> e.g. in the gui I'm missing up to the last 10 minutes now?
> (at 14:49 the last point i have for the rrd is from 14:40)
> 
> is this by design? i get that we don't want to pull too often,
> but showing up to 10minutes out of date graphs is also not practical?

Yes this was by design, or well indeed mine and also Dietmars request.
But surely something that might warrant a central knob with a per
remote override in the future (or smarter heuristics depending on
remote node count and latency, i.e. how long the last few metric
queries took on average).

But the idea was also to fetch missing data on demand if required, e.g.
when a user visits a specific resource with a time frame length where
this is noticeable, like you mentioned that it mostly sticks out for
the last-hour time frame.

> my naive solution would be to proxy the rrd requests to the
> pve nodes directly, but then why would we need the metric
> collection in the first place?

Those two are a bit orthogonal to each other, we want RRD collection
to not depend on every remote having to be online all the time (to see
when it went offline, to avoid high latency to add many delays, ...), and
being able to do quick metrics and stats computations on all resources
(which will never be 100% real time anyway). The other is seeing most
recent data, e.g. when investigating why something is slow or what not.




_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel


  parent reply	other threads:[~2025-08-27  7:20 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-08-21  9:52 Lukas Wagner
2025-08-21  9:52 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 01/23] metric collection: split top_entities split into separate module Lukas Wagner
2025-08-21  9:52 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 02/23] metric collection: save metric data to RRD in separate task Lukas Wagner
2025-08-21  9:52 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 03/23] metric collection: rework metric poll task Lukas Wagner
2025-08-21  9:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 04/23] metric collection: persist state after metric collection Lukas Wagner
2025-08-21  9:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 05/23] metric collection: skip if last_collection < MIN_COLLECTION_INTERVAL Lukas Wagner
2025-08-21  9:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 06/23] metric collection: collect overdue metrics on startup/timer change Lukas Wagner
2025-08-21  9:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 07/23] metric collection: add tests for the fetch_remotes function Lukas Wagner
2025-08-21  9:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 08/23] metric collection: add test for fetch_overdue Lukas Wagner
2025-08-21  9:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 09/23] metric collection: pass rrd cache instance as function parameter Lukas Wagner
2025-08-21  9:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 10/23] metric collection: add test for rrd task Lukas Wagner
2025-08-21  9:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 11/23] metric collection: wrap rrd_cache::Cache in a struct Lukas Wagner
2025-08-21  9:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 12/23] metric collection: record remote response time in metric database Lukas Wagner
2025-08-21  9:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 13/23] metric collection: save time needed for collection run to RRD Lukas Wagner
2025-08-21  9:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 14/23] metric collection: periodically clean removed remotes from statefile Lukas Wagner
2025-08-21  9:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 15/23] api: add endpoint to trigger metric collection Lukas Wagner
2025-08-21  9:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 16/23] api: remotes: trigger immediate metric collection for newly added nodes Lukas Wagner
2025-08-21  9:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 17/23] api: add api for querying metric collection RRD data Lukas Wagner
2025-08-21  9:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 18/23] api: metric-collection: add status endpoint Lukas Wagner
2025-08-21  9:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 19/23] pdm-client: add metric collection API methods Lukas Wagner
2025-08-21  9:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 20/23] cli: add commands for metric-collection trigger and status Lukas Wagner
2025-08-21  9:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 21/23] metric collection: factor out handle_tick and handle_control_message fns Lukas Wagner
2025-08-21  9:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 22/23] metric collection: skip missed timer ticks Lukas Wagner
2025-08-21  9:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 23/23] metric collection: use JoinSet instead of joining from handles in a Vec Lukas Wagner
2025-08-21 12:53 ` [pdm-devel] [PATCH proxmox-datacenter-manager v6 00/23] metric collection improvements (concurrency, API, CLI) Dominik Csapak
2025-08-21 13:46   ` Lukas Wagner
2025-08-22 11:27     ` Dominik Csapak
2025-08-27  7:19   ` Thomas Lamprecht [this message]
2025-08-22 11:51 ` Dominik Csapak
2025-08-22 12:49   ` Dominik Csapak
2025-08-25  8:43   ` Lukas Wagner
2025-08-26 13:53 ` [pdm-devel] superseded: " Lukas Wagner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5b4de73b-2be5-463a-9b03-167df8354a65@proxmox.com \
    --to=t.lamprecht@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=l.wagner@proxmox.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal