public inbox for pdm-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: James Tremblay <james.tremblay@telrite.com>
To: pdm-devel@lists.proxmox.com
Subject: Re: [pdm-devel] [PATCH datacenter-manager/proxmox/yew-comp v2 00/13] Add LDAP and AD realm support to Proxmox Datacenter Manager
Date: Fri, 3 Oct 2025 13:40:09 -0400	[thread overview]
Message-ID: <494a2532-5ef7-4712-aaaf-03972792de50@telrite.com> (raw)
In-Reply-To: <DD7U8B8YOK28.7WQH0QZAZZZY@proxmox.com>

Shannon, thanks for the reply. I made a couple of modifications and 
fixed it!
JT

On 10/2/25 8:38 AM, Shannon Sterz wrote:
> On Tue Sep 30, 2025 at 5:12 PM CEST, James Tremblay wrote:
>> I am following this issue with interest. I am running an upgrade from
>> alpha to beta and fully "patched"
>> I have looked at my PBS  \ PVE configuration for AD \ LDAP and i'm getting
>>
>> Login failed. Please try again (api error (status = 401: Unauthorized))
>>
>> is this expected?
> this is probably better discussed on our bugzilla. there is an issue
> there already for pdm's ldap/ad support [1]. could you provide some more
> detail though?
>
> - what does your configuration look like in
>    `/etc/proxmox-datacenter-manager/access/domains.cfg`?
> - is there something in the journal when you log in?
> - is the user in `/etc/proxmox-datacenter-manager/access/user.cfg`
>    enabled?
>
> thanks in advance!
>
> [1]: https://bugzilla.proxmox.com/show_bug.cgi?id=6793
>
>> On 9/22/25 11:05 AM, Shannon Sterz wrote:
>>> this patch series adds ldap and active directory (ad) support to proxmox
>>> datacenter manager. the series first moves some of the sync logic for
>>> ldap & ad realms out of proxmox backup manager into the proxmox-ldap
>>> crate.
>>>
>>> the next series of patches fixes up the existing proxmox-yew-comp
>>> components for adding and editing realms to function as intended for
>>> adding, editing, removing and syncing ad and ldap realms.
>>>
>>> finally, we add the necessary backend infrastructure and api endpoints
>>> to proxmox datacenter manager and expose the new ui components there.
>>>
>>> this series does not yet move proxmox backup server to use the new
>>> common crate. doing so would mean that proxmox backup server would also
>>> need to start using proxmox-access-control, which would be a lot more
>>> involved and is beste handled in a separate series in my opinion.
>>>
>>> Changelog
>>> ---------
>>>
>>> changes since v1, thanks @ Christoph Heiss:
>>>
>>> - added a patch to adjust the layout and placeholders for the edit/add
>>>     window of ldap and ad realms
>>> - made the sync dialog respect the configured sync settings for the
>>>     realm
>>> - made the user management component reload when being re-opened, so the
>>>     state isn't cached.
>>>
>>> things from Christoph's notes that i haven't touched:
>>>
>>> - did not add comment syncing as that isn't part of pbs either (if we
>>>     want to add that, imo we should do so after we factored out pbs' code
>>>     properly)
>>> - "Enable new users" did behave as inteded in my testing
>>> - no realm being ticket as default if default isn't set (this matches
>>>     pbs' behaviour but i'll tackle further default realm support in
>>>     general in a follo up series)
>>> - cli support will be tackled in a follow (depends on whether we want to
>>>     factor out more of the api parts or not)
>>>
>>> see also the discussion in the old thread [1].
>>>
>>> [1]:https://lore.proxmox.com/pdm-devel/DCZDLVQC9V6B.30GUQRQFGXCX6@proxmox.com/T/#u
>>>
>>> proxmox:
>>>
>>> Shannon Sterz (1):
>>>     ldap: add types and sync features
>>>
>>>    Cargo.toml                    |   2 +-
>>>    proxmox-ldap/Cargo.toml       |  22 ++
>>>    proxmox-ldap/debian/control   |  31 ++-
>>>    proxmox-ldap/debian/copyright |   2 +-
>>>    proxmox-ldap/src/lib.rs       |   6 +
>>>    proxmox-ldap/src/sync.rs      | 496 ++++++++++++++++++++++++++++++++++
>>>    proxmox-ldap/src/types.rs     | 317 ++++++++++++++++++++++
>>>    7 files changed, 873 insertions(+), 3 deletions(-)
>>>    create mode 100644 proxmox-ldap/src/sync.rs
>>>    create mode 100644 proxmox-ldap/src/types.rs
>>>
>>>
>>> proxmox-yew-comp:
>>>
>>> Shannon Sterz (6):
>>>     auth_view: add default column and allow setting ldap realms as default
>>>     utils: add pdm realm to `get_auth_domain_info`
>>>     auth_view/auth_edit_ldap: add support for active directory realms
>>>     auth_edit_ldap: add helpers to properly edit ad & ldap realms
>>>     auth_view: implement syncing ldap and ad realms
>>>     auth_edit_ldap: improve form layout and placeholders
>>>
>>>    src/auth_edit_ldap.rs   | 215 ++++++++++++++++++++++++++++++--------
>>>    src/auth_view.rs        | 223 +++++++++++++++++++++++++++++++++++++---
>>>    src/common_api_types.rs |   3 +
>>>    src/utils.rs            |  18 +---
>>>    4 files changed, 392 insertions(+), 67 deletions(-)
>>>
>>>
>>> proxmox-datacenter-manager:
>>>
>>> Shannon Sterz (6):
>>>     config: add domain config plugins for ldap and ad realms
>>>     server: add ldap and active directory authenticators
>>>     server: api: add api endpoints for configuring ldap & ad realms
>>>     api/auth: add endpoint to start ldap sync jobs
>>>     ui: add a panel to allow handling realms
>>>     ui: make the user tab reload when re-opened
>>>
>>>    Cargo.toml                           |   1 +
>>>    lib/pdm-api-types/src/acl.rs         |   3 +
>>>    lib/pdm-api-types/src/lib.rs         |   7 +
>>>    lib/pdm-config/Cargo.toml            |   1 +
>>>    lib/pdm-config/src/domains.rs        |  35 +++
>>>    server/Cargo.toml                    |   1 +
>>>    server/src/api/access/domains.rs     |  90 ++++++-
>>>    server/src/api/config/access/ad.rs   | 355 +++++++++++++++++++++++++
>>>    server/src/api/config/access/ldap.rs | 372 +++++++++++++++++++++++++++
>>>    server/src/api/config/access/mod.rs  |   8 +-
>>>    server/src/auth/ldap.rs              | 315 +++++++++++++++++++++++
>>>    server/src/auth/mod.rs               |  17 +-
>>>    ui/src/configuration/mod.rs          |  26 +-
>>>    13 files changed, 1221 insertions(+), 10 deletions(-)
>>>    create mode 100644 server/src/api/config/access/ad.rs
>>>    create mode 100644 server/src/api/config/access/ldap.rs
>>>    create mode 100644 server/src/auth/ldap.rs
>>>
>>>
>>> Summary over all repositories:
>>>     24 files changed, 2486 insertions(+), 80 deletions(-)
>>>
>>> --
>>> Generated by git-murpp 0.8.1
>>>
>>>
>>> _______________________________________________
>>> pdm-devel mailing list
>>> pdm-devel@lists.proxmox.com
>>> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel
>>>
>>>
>
>
> _______________________________________________
> pdm-devel mailing list
> pdm-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

_______________________________________________
pdm-devel mailing list
pdm-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pdm-devel

      reply	other threads:[~2025-10-03 17:40 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-22 15:05 Shannon Sterz
2025-09-22 15:05 ` [pdm-devel] [PATCH proxmox v2 1/1] ldap: add types and sync features Shannon Sterz
2025-09-22 18:28   ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-22 15:05 ` [pdm-devel] [PATCH yew-comp v2 1/6] auth_view: add default column and allow setting ldap realms as default Shannon Sterz
2025-09-22 19:00   ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-22 15:05 ` [pdm-devel] [PATCH yew-comp v2 2/6] utils: add pdm realm to `get_auth_domain_info` Shannon Sterz
2025-09-22 19:00   ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-22 15:05 ` [pdm-devel] [PATCH yew-comp v2 3/6] auth_view/auth_edit_ldap: add support for active directory realms Shannon Sterz
2025-09-22 19:00   ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-22 15:05 ` [pdm-devel] [PATCH yew-comp v2 4/6] auth_edit_ldap: add helpers to properly edit ad & ldap realms Shannon Sterz
2025-09-22 19:00   ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-22 15:05 ` [pdm-devel] [PATCH yew-comp v2 5/6] auth_view: implement syncing ldap and ad realms Shannon Sterz
2025-09-22 19:00   ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-22 15:05 ` [pdm-devel] [PATCH yew-comp v2 6/6] auth_edit_ldap: improve form layout and placeholders Shannon Sterz
2025-09-22 19:00   ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-22 15:05 ` [pdm-devel] [PATCH datacenter-manager v2 1/6] config: add domain config plugins for ldap and ad realms Shannon Sterz
2025-09-22 19:03   ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-22 15:05 ` [pdm-devel] [PATCH datacenter-manager v2 2/6] server: add ldap and active directory authenticators Shannon Sterz
2025-09-22 19:03   ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-22 15:05 ` [pdm-devel] [PATCH datacenter-manager v2 3/6] server: api: add api endpoints for configuring ldap & ad realms Shannon Sterz
2025-09-22 19:03   ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-22 15:05 ` [pdm-devel] [PATCH datacenter-manager v2 4/6] api/auth: add endpoint to start ldap sync jobs Shannon Sterz
2025-09-22 19:03   ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-22 15:05 ` [pdm-devel] [PATCH datacenter-manager v2 5/6] ui: add a panel to allow handling realms Shannon Sterz
2025-09-22 19:03   ` [pdm-devel] applied: " Thomas Lamprecht
2025-09-22 15:05 ` [pdm-devel] [PATCH datacenter-manager v2 6/6] ui: make the user tab reload when re-opened Shannon Sterz
2025-09-22 19:03   ` [pdm-devel] applied: " Thomas Lamprecht
     [not found] ` <13dc8878-60d1-456b-9bc9-4d2700a92ec6@telrite.com>
2025-10-02 12:38   ` [pdm-devel] [PATCH datacenter-manager/proxmox/yew-comp v2 00/13] Add LDAP and AD realm support to Proxmox Datacenter Manager Shannon Sterz
2025-10-03 17:40     ` James Tremblay [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=494a2532-5ef7-4712-aaaf-03972792de50@telrite.com \
    --to=james.tremblay@telrite.com \
    --cc=pdm-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal