From: Thomas Lamprecht <t.lamprecht@proxmox.com>
To: Dominik Csapak <d.csapak@proxmox.com>,
pdm-devel@lists.proxmox.com, Shan Shaji <s.shaji@proxmox.com>
Subject: Re: applied: [PATCH datacenter-manager/proxmox v4 0/7] fix #6914: add option to remove already existing token
Date: Mon, 9 Mar 2026 23:05:46 +0100 [thread overview]
Message-ID: <45459a77-bbd6-4028-9dd6-3a5153b16394@proxmox.com> (raw)
In-Reply-To: <0908109e-62d7-4979-9909-182bc16752cb@proxmox.com>
Am 09.03.26 um 10:43 schrieb Dominik Csapak:
> it seems the 2/6 commit is missing here, meaning the ui now uses an
> option on delete that is not there in the api, was this
> intentional? (i.e. is there something wrong with the patch from
> your side?)
Argh, that has been lost on a rebase, and the final compile test naturally
could not catch that. Thanks for the hint, fixed now and pushed that one too.
prev parent reply other threads:[~2026-03-09 22:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-18 16:41 Shan Shaji
2026-02-18 16:41 ` [PATCH datacenter-manager v4 1/6] server: pbs-client: add method to delete token from remote Shan Shaji
2026-02-18 16:41 ` [PATCH datacenter-manager v4 2/6] fix #6914: api: add support " Shan Shaji
2026-02-18 16:41 ` [PATCH datacenter-manager v4 3/6] pdm-client: accept `delete-token` argument for deleting api token Shan Shaji
2026-02-18 16:41 ` [PATCH datacenter-manager v4 4/6] fix #6914: cli-client: add option to delete token from remote Shan Shaji
2026-02-18 16:41 ` [PATCH datacenter-manager v4 5/6] fix #6914: ui: add remove remote dialog with optional token deletion Shan Shaji
2026-02-18 16:41 ` [PATCH datacenter-manager v4 6/6] fix #6914: cli-admin: add option to delete token from remote Shan Shaji
2026-02-18 16:41 ` [PATCH proxmox v4 1/1] pve-api-types: generate missing `delete_token` method Shan Shaji
2026-03-09 20:52 ` applied: " Thomas Lamprecht
2026-02-24 13:06 ` [PATCH datacenter-manager/proxmox v4 0/7] fix #6914: add option to remove already existing token Lukas Wagner
2026-03-08 18:23 ` applied: " Thomas Lamprecht
2026-03-09 9:44 ` Dominik Csapak
2026-03-09 22:05 ` Thomas Lamprecht [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45459a77-bbd6-4028-9dd6-3a5153b16394@proxmox.com \
--to=t.lamprecht@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pdm-devel@lists.proxmox.com \
--cc=s.shaji@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox